Skip to content

chore: set ca_cert_identifier to null to use AWS defaults #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

bryantbiggs
Copy link
Member

Description

  • set ca_cert_identifier to null to use AWS defaults
  • update pre-commit to latest and format docs

Motivation and Context

closes #224

Breaking Changes

no

How Has This Been Tested?

  • I have tested and validated these changes using one or more of the provided examples/* projects

@bryantbiggs bryantbiggs requested a review from antonbabenko July 9, 2021 02:13
@bryantbiggs bryantbiggs marked this pull request as draft October 16, 2021 17:32
@bryantbiggs
Copy link
Member Author

pausing this for a moment

@yongzhang
Copy link

pausing this for a moment

will this be added to PR #243?

@bryantbiggs
Copy link
Member Author

@yongzhang yes, it is included in that PR

@bryantbiggs bryantbiggs deleted the chore/set-ca-cert-identifier-null branch October 25, 2021 19:33
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for opt-in AWS Regions - remove ca_cert_identifier default value
2 participants