-
-
Notifications
You must be signed in to change notification settings - Fork 590
feat: add custom cluster endpoints #233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add custom cluster endpoints #233
Conversation
READER type will be empty in case we run a single node cluster. Endpoints will have enabled the option "Attach future instances added to this cluster" by default |
For outputs, I took the same design as for the VPC module |
@bryantbiggs @antonbabenko Anything else we need to add or describe? |
main.tf
Outdated
custom_endpoint_type = each.value | ||
|
||
lifecycle { | ||
ignore_changes = [excluded_members, static_members] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't yet know what the ramifications of this are. we don't have these attributes set here, and yet we are ignoring them from future changes. we generally try to avoid the use of the ignore_changes
lifecycle hook because it cannot be parameterized. I will have to do some tests to see what makes the most sense for this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll do a couple of tests on my own. I am currently using this version and will check the behavior without ignoring
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can use static_members
for case then we need include only instances created by Terraform (by this module)
If we need reader endpoints only with nodes managed from iac.
And we can use excluded_members
for case then we need exclude all instances created by this module.
By default both will be empty
var.cluster_custom_endpoints_only_static_members = false
var.cluster_custom_endpoints_all_excluded_members = false
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Description
Motivation and Context
Aurora.Endpoints.Custom
How Has This Been Tested?
examples/*
projectsAdditional info
READER type will be empty in case we run a single node cluster.
Because there are no readers. Just one writer node.
Endpoints will have enabled the option "Attach future instances added to this cluster" by default
Because there are no static_members and we ignore them for now
Future improvments