Skip to content

This change allows the module to create an Aurora Global database acc… #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

This change allows the module to create an Aurora Global database acc… #237

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,8 +61,8 @@ resource "aws_rds_cluster" "this" {
enable_http_endpoint = var.enable_http_endpoint
kms_key_id = var.kms_key_id
database_name = var.database_name
master_username = var.username
master_password = local.master_password
master_username = var.is_primary_cluster == false ? null : var.username
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
master_username = var.is_primary_cluster == false ? null : var.username
master_username = var.is_primary_cluster ? var.username : null

master_password = var.is_primary_cluster == false ? null : local.master_password
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
master_password = var.is_primary_cluster == false ? null : local.master_password
master_password = var.is_primary_cluster ? local.master_password : null

final_snapshot_identifier = "${var.final_snapshot_identifier_prefix}-${var.name}-${element(concat(random_id.snapshot_identifier.*.hex, [""]), 0)}"
skip_final_snapshot = var.skip_final_snapshot
deletion_protection = var.deletion_protection
Expand Down