feat: Add support for creating CloudWatch log groups #346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryantbiggs
approved these changes
Jan 1, 2023
bryantbiggs
changed the title
bryantbiggs
force-pushed
the
feat/manage_cloudwatch_log_groups
branch
from
63bcdb9 to
b8f1e67
Compare
|
Oy, looks like we'll have to merge this after #335 |
|
looking forward to this PR. |
magreenbaum
commented
Feb 12, 2023
| @@ -442,7 +442,7 @@ resource "aws_db_parameter_group" "this" { | |||
| ################################################################################ | |||
|
|
|||
| resource "aws_cloudwatch_log_group" "this" { | |||
| for_each = toset([for log in var.enabled_cloudwatch_logs_exports : log if local.create_cluster && var.create_cloudwatch_log_group]) | |||
| for_each = toset([for log in var.enabled_cloudwatch_logs_exports : log if local.create_cluster && var.create_cloudwatch_log_group && !var.cluster_use_name_prefix]) | |||
There was a problem hiding this comment.
Updated cloudwatch log group creation based on this feedback which is also relevant to this module.
|
CI is green so merging! |
antonbabenko
pushed a commit
that referenced
this pull request
Mar 6, 2023
## [7.7.0](v7.6.2...v7.7.0) (2023-03-06) ### Features * Add support for creating CloudWatch log groups ([#346](#346)) ([40cef84](40cef84))
|
This PR is included in version 7.7.0 🎉 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add cloudwatch log group management.
Motivation and Context
Breaking Changes
No.
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request