feat: S3 table and table bucket CMK encryption support #327
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magreenbaum
commented
May 16, 2025
| variable "maintenance_configuration" { | ||
| description = "Map of table bucket maintenance configurations" | ||
| type = any | ||
| default = {} | ||
| default = null |
There was a problem hiding this comment.
Turns out if you don't specify maintenance_configuration and rely on this default value, an error occurs unless null.
╷
│ Error: Incorrect attribute value type
│
│ on ../../modules/table-bucket/main.tf line 6, in resource "aws_s3tables_table_bucket" "this":
│ 6: maintenance_configuration = var.maintenance_configuration
│ ├────────────────
│ │ var.maintenance_configuration is object with no attributes
│
│ Inappropriate value for attribute "maintenance_configuration": attribute "iceberg_unreferenced_file_removal" is required.
╵
antonbabenko
approved these changes
May 16, 2025
antonbabenko
pushed a commit
that referenced
this pull request
May 16, 2025
## [4.9.0](v4.8.0...v4.9.0) (2025-05-16) ### Features * S3 table and table bucket CMK encryption support ([#327](#327)) ([541232b](541232b))
|
This PR is included in version 4.9.0 🎉 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for table bucket and table CMK encryption.
Also fix default value of
maintenance_configurationto allow for passing no configuration.Motivation and Context
hashicorp/terraform-provider-aws#42356
Breaking Changes
No.
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request