Skip to content

fix: Use IPv6 CIDR block destination on route when IPv6 support is enabled #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Dec 11, 2023
Merged

fix: Use IPv6 CIDR block destination on route when IPv6 support is enabled #102

merged 5 commits into from
Dec 11, 2023

Conversation

Jarodiv
Copy link
Contributor

@Jarodiv Jarodiv commented Feb 13, 2023 •
edited by bryantbiggs
Loading

Description

Make route creation use aws_route.destination_ipv6_cidr_block for attachments with ipv6_support set to true.

Motivation and Context

Creating routes for TGW attachments breaks the generally working support for IPv6 based setups.

Breaking Changes

There should be no negative effect on backwards compatibility with the current major version.

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@Jarodiv Jarodiv changed the title Fix: Using IPv6 with 'vpc_attachments[].vpc_route_table_ids' fails fix: Using IPv6 with vpc_attachments[].vpc_route_table_ids fails Feb 13, 2023
@bryantbiggs bryantbiggs mentioned this pull request Mar 6, 2023
Closed
3 tasks
@github-actions
Copy link

github-actions bot commented Apr 6, 2023

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions bot added the stale label Apr 6, 2023
@Jarodiv
Copy link
Contributor Author

Jarodiv commented Apr 6, 2023

"Keep alive" post

@github-actions github-actions bot removed the stale label Apr 7, 2023
@github-actions
Copy link

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions bot added the stale label May 31, 2023
@Jarodiv
Copy link
Contributor Author

Jarodiv commented Jun 1, 2023

"Keep alive" post

@github-actions github-actions bot removed the stale label Jun 2, 2023
@bmurphey bmurphey mentioned this pull request Jun 20, 2023
Open
3 tasks
@github-actions
Copy link

github-actions bot commented Jul 2, 2023

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions bot added the stale label Jul 2, 2023
@Jarodiv
Copy link
Contributor Author

Jarodiv commented Jul 3, 2023

"Keep alive" post

@github-actions github-actions bot removed the stale label Jul 4, 2023
@github-actions
Copy link

github-actions bot commented Aug 4, 2023

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions bot added the stale label Aug 4, 2023
@Jarodiv
Copy link
Contributor Author

Jarodiv commented Aug 5, 2023

"Keep alive" post"Keep alive" post

@github-actions github-actions bot removed the stale label Aug 6, 2023
@github-actions
Copy link

github-actions bot commented Sep 6, 2023

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions bot added the stale label Sep 6, 2023
@Jarodiv
Copy link
Contributor Author

Jarodiv commented Sep 12, 2023

"Keep alive" post

@github-actions github-actions bot removed the stale label Sep 13, 2023
@github-actions
Copy link

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions bot added the stale label Oct 13, 2023
@Jarodiv
Copy link
Contributor Author

Jarodiv commented Oct 13, 2023

"Keep alive" post

@github-actions github-actions bot removed the stale label Oct 14, 2023
@github-actions GitHub Actions
Copy link

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions bot added the stale label Nov 13, 2023
@Jarodiv
Copy link
Contributor Author

Jarodiv commented Nov 13, 2023

"Keep alive" post

@github-actions github-actions bot removed the stale label Nov 14, 2023
bryantbiggs
bryantbiggs reviewed Dec 11, 2023
View reviewed changes
@bryantbiggs bryantbiggs changed the title fix: Using IPv6 with vpc_attachments[].vpc_route_table_ids fails fix: Use IPv6 CIDR block destination on route when IPv6 support is enabled Dec 11, 2023
bryantbiggs
bryantbiggs approved these changes Dec 11, 2023
View reviewed changes
Copy link
Member

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@bryantbiggs bryantbiggs merged commit f70ec98 into terraform-aws-modules:master Dec 11, 2023
antonbabenko pushed a commit that referenced this pull request Dec 11, 2023
@semantic-release-bot
chore(release): version 2.12.1 [skip ci]
c41629d 
### [2.12.1](v2.12.0...v2.12.1) (2023-12-11)

### Bug Fixes

* Use IPv6 CIDR block destination on route when IPv6 support is enabled ([#102](#102)) ([f70ec98](f70ec98))
@antonbabenko
Copy link
Member

This PR is included in version 2.12.1 🎉

@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bryantbiggs bryantbiggs bryantbiggs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using IPv6 with vpc_attachments[].vpc_route_table_ids fails Using IPv6 with vpc_attachments[].vpc_route_table_ids fails
3 participants
@Jarodiv @antonbabenko @bryantbiggs