Skip to content

feat: Support multiple tgw route tables (v2) #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

flah00
Copy link

@flah00 flah00 commented Feb 12, 2025

Description

Based on issues#139, attempt to add support for multiple route tables for a single tgw.

Of course we're all looking forward to #113. But just in case its release is not imminent.. This could tide us over?

Motivation and Context

issues#139

Breaking Changes

Additive, it's a new module

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@flah00 flah00 changed the title Support multiple tgw route tables (v2) feat: Support multiple tgw route tables (v2) Feb 12, 2025
@flah00
Copy link
Author

flah00 commented Mar 7, 2025

@antonbabenko @bryantbiggs bump :)

@bryantbiggs
Copy link
Member

I don't think we'll be proceeding with this one - it doesn't make a lot of sense to add a temporary sub-module to unblock this. if this is a suitable solution for the interim, users can implement it on their own - we don't want to take on the burden of trying to migrate users off this at a later date

@flah00
Copy link
Author

flah00 commented Mar 7, 2025

Fair enough
Is there anything we can do to help get v3 over the line?

Copy link

github-actions bot commented Apr 7, 2025

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions bot added the stale label Apr 7, 2025
Copy link

This PR was automatically closed because of stale in 10 days

@github-actions github-actions bot closed this Apr 18, 2025
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants