refactor: replace non-default lookup() calls with direct access (#2113)

wyardley · web-flow · commit 3a23cd4daaea · 2024-09-25T19:16:43.000Z
diff --git a/autogen/main/cluster.tf.tmpl b/autogen/main/cluster.tf.tmpl
@@ -184,9 +184,9 @@ resource "google_container_cluster" "primary" {
     dynamic "resource_limits" {
       for_each = local.autoscaling_resource_limits
       content {
-        resource_type = lookup(resource_limits.value, "resource_type")
-        minimum       = lookup(resource_limits.value, "minimum")
-        maximum       = lookup(resource_limits.value, "maximum")
+        resource_type = resource_limits.value["resource_type"]
+        minimum       = resource_limits.value["minimum"]
+        maximum       = resource_limits.value["maximum"]
       }
     }
   }
diff --git a/cluster.tf b/cluster.tf
@@ -154,9 +154,9 @@ resource "google_container_cluster" "primary" {
     dynamic "resource_limits" {
       for_each = local.autoscaling_resource_limits
       content {
-        resource_type = lookup(resource_limits.value, "resource_type")
-        minimum       = lookup(resource_limits.value, "minimum")
-        maximum       = lookup(resource_limits.value, "maximum")
+        resource_type = resource_limits.value["resource_type"]
+        minimum       = resource_limits.value["minimum"]
+        maximum       = resource_limits.value["maximum"]
       }
     }
   }
diff --git a/modules/beta-private-cluster-update-variant/cluster.tf b/modules/beta-private-cluster-update-variant/cluster.tf
@@ -161,9 +161,9 @@ resource "google_container_cluster" "primary" {
     dynamic "resource_limits" {
       for_each = local.autoscaling_resource_limits
       content {
-        resource_type = lookup(resource_limits.value, "resource_type")
-        minimum       = lookup(resource_limits.value, "minimum")
-        maximum       = lookup(resource_limits.value, "maximum")
+        resource_type = resource_limits.value["resource_type"]
+        minimum       = resource_limits.value["minimum"]
+        maximum       = resource_limits.value["maximum"]
       }
     }
   }
diff --git a/modules/beta-private-cluster/cluster.tf b/modules/beta-private-cluster/cluster.tf
@@ -161,9 +161,9 @@ resource "google_container_cluster" "primary" {
     dynamic "resource_limits" {
       for_each = local.autoscaling_resource_limits
       content {
-        resource_type = lookup(resource_limits.value, "resource_type")
-        minimum       = lookup(resource_limits.value, "minimum")
-        maximum       = lookup(resource_limits.value, "maximum")
+        resource_type = resource_limits.value["resource_type"]
+        minimum       = resource_limits.value["minimum"]
+        maximum       = resource_limits.value["maximum"]
       }
     }
   }
diff --git a/modules/beta-public-cluster-update-variant/cluster.tf b/modules/beta-public-cluster-update-variant/cluster.tf
@@ -161,9 +161,9 @@ resource "google_container_cluster" "primary" {
     dynamic "resource_limits" {
       for_each = local.autoscaling_resource_limits
       content {
-        resource_type = lookup(resource_limits.value, "resource_type")
-        minimum       = lookup(resource_limits.value, "minimum")
-        maximum       = lookup(resource_limits.value, "maximum")
+        resource_type = resource_limits.value["resource_type"]
+        minimum       = resource_limits.value["minimum"]
+        maximum       = resource_limits.value["maximum"]
       }
     }
   }
diff --git a/modules/beta-public-cluster/cluster.tf b/modules/beta-public-cluster/cluster.tf
@@ -161,9 +161,9 @@ resource "google_container_cluster" "primary" {
     dynamic "resource_limits" {
       for_each = local.autoscaling_resource_limits
       content {
-        resource_type = lookup(resource_limits.value, "resource_type")
-        minimum       = lookup(resource_limits.value, "minimum")
-        maximum       = lookup(resource_limits.value, "maximum")
+        resource_type = resource_limits.value["resource_type"]
+        minimum       = resource_limits.value["minimum"]
+        maximum       = resource_limits.value["maximum"]
       }
     }
   }
diff --git a/modules/private-cluster-update-variant/cluster.tf b/modules/private-cluster-update-variant/cluster.tf
@@ -154,9 +154,9 @@ resource "google_container_cluster" "primary" {
     dynamic "resource_limits" {
       for_each = local.autoscaling_resource_limits
       content {
-        resource_type = lookup(resource_limits.value, "resource_type")
-        minimum       = lookup(resource_limits.value, "minimum")
-        maximum       = lookup(resource_limits.value, "maximum")
+        resource_type = resource_limits.value["resource_type"]
+        minimum       = resource_limits.value["minimum"]
+        maximum       = resource_limits.value["maximum"]
       }
     }
   }
diff --git a/modules/private-cluster/cluster.tf b/modules/private-cluster/cluster.tf
@@ -154,9 +154,9 @@ resource "google_container_cluster" "primary" {
     dynamic "resource_limits" {
       for_each = local.autoscaling_resource_limits
       content {
-        resource_type = lookup(resource_limits.value, "resource_type")
-        minimum       = lookup(resource_limits.value, "minimum")
-        maximum       = lookup(resource_limits.value, "maximum")
+        resource_type = resource_limits.value["resource_type"]
+        minimum       = resource_limits.value["minimum"]
+        maximum       = resource_limits.value["maximum"]
       }
     }
   }

Original file line number	Diff line number	Diff line change
`@@ -184,9 +184,9 @@ resource "google_container_cluster" "primary" {`
`184`	`184`	`dynamic "resource_limits" {`
`185`	`185`	`for_each = local.autoscaling_resource_limits`
`186`	`186`	`content {`
`187`		`- resource_type = lookup(resource_limits.value, "resource_type")`
`188`		`- minimum = lookup(resource_limits.value, "minimum")`
`189`		`- maximum = lookup(resource_limits.value, "maximum")`
	`187`	`+ resource_type = resource_limits.value["resource_type"]`
	`188`	`+ minimum = resource_limits.value["minimum"]`
	`189`	`+ maximum = resource_limits.value["maximum"]`
`190`	`190`	`}`
`191`	`191`	`}`
`192`	`192`	`}`
Original file line number	Diff line number	Diff line change
`@@ -154,9 +154,9 @@ resource "google_container_cluster" "primary" {`
`154`	`154`	`dynamic "resource_limits" {`
`155`	`155`	`for_each = local.autoscaling_resource_limits`
`156`	`156`	`content {`
`157`		`- resource_type = lookup(resource_limits.value, "resource_type")`
`158`		`- minimum = lookup(resource_limits.value, "minimum")`
`159`		`- maximum = lookup(resource_limits.value, "maximum")`
	`157`	`+ resource_type = resource_limits.value["resource_type"]`
	`158`	`+ minimum = resource_limits.value["minimum"]`
	`159`	`+ maximum = resource_limits.value["maximum"]`
`160`	`160`	`}`
`161`	`161`	`}`
`162`	`162`	`}`
Original file line number	Diff line number	Diff line change
`@@ -161,9 +161,9 @@ resource "google_container_cluster" "primary" {`
`161`	`161`	`dynamic "resource_limits" {`
`162`	`162`	`for_each = local.autoscaling_resource_limits`
`163`	`163`	`content {`
`164`		`- resource_type = lookup(resource_limits.value, "resource_type")`
`165`		`- minimum = lookup(resource_limits.value, "minimum")`
`166`		`- maximum = lookup(resource_limits.value, "maximum")`
	`164`	`+ resource_type = resource_limits.value["resource_type"]`
	`165`	`+ minimum = resource_limits.value["minimum"]`
	`166`	`+ maximum = resource_limits.value["maximum"]`
`167`	`167`	`}`
`168`	`168`	`}`
`169`	`169`	`}`