Skip to content

refactor: replace non-default lookup() calls with direct access #2113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

wyardley
Copy link
Contributor

Resolve terraform_deprecated_lookup warning for lookup() calls with only 2 arguments (no default).

See:
https://github.com/terraform-linters/tflint-ruleset-terraform/blob/main/docs/rules/terraform_deprecated_lookup.md

@wyardley wyardley requested review from ericyz, gtsorbo and a team as code owners September 25, 2024 00:57
@wyardley wyardley changed the title refactor: use direct key lookup for lookup() calls refactor: replace non-default lookup() calls with direct access Sep 25, 2024
@apeabody
Copy link
Collaborator

/gcbrun

Copy link
Collaborator

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @wyardley!

@apeabody
Copy link
Collaborator

/gcbrun

@apeabody apeabody enabled auto-merge (squash) September 25, 2024 18:26
@apeabody apeabody disabled auto-merge September 25, 2024 18:26
@apeabody apeabody enabled auto-merge (squash) September 25, 2024 18:26
@apeabody apeabody merged commit 3a23cd4 into terraform-google-modules:master Sep 25, 2024
4 checks passed
@wyardley wyardley deleted the wyardley/refactor/tflint branch September 25, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants