feat: add gcp_filestore_csi_driver_config to addons config #1161

davidspek · 2022-02-24T19:23:47Z

Rebased version of #1145

#1030
Signed-off-by: DavidSpek [email protected]

davidspek · 2022-02-24T19:34:44Z

@bharathkkb Is there a way to see what's causing the failure? I think it might be caused by the provider bump.

comment-bot-dev · 2022-02-24T19:39:45Z

Thanks for the PR! 🚀
Unfortunately it looks like some of our CI checks failed. See the Contributing Guide for details.

⚠️check_terraform
Failed Terraform check. More details below.

Running terraform fmt
Running terraform validate
terraform_validate . 
╷
│

Error: 
Unsupported block type
│

│

 on cluster.tf line 113, in resource "google_container_cluster" "primary":
│

113:       
gcp_filestore_csi_driver_config
{
│

│

Blocks of type "gcp_filestore_csi_driver_config" are not expected here.
╵
terraform_validate ./examples/acm-terraform-blog-part1/terraform 
Success!
The configuration is valid.
terraform_validate ./examples/acm-terraform-blog-part2/terraform 
Success!
The configuration is valid.
terraform_validate ./examples/acm-terraform-blog-part3/terraform 
Success!
The configuration is valid.
terraform_validate ./examples/deploy_service 
╷
│

Error: 
Unsupported block type
│

│

 on ../../cluster.tf line 113, in resource "google_container_cluster" "primary":
│

113:       
gcp_filestore_csi_driver_config
{
│

│

Blocks of type "gcp_filestore_csi_driver_config" are not expected here.
╵
terraform_validate ./examples/disable_client_cert 
╷
│

Error: 
Unsupported block type
│

│

 on ../../cluster.tf line 113, in resource "google_container_cluster" "primary":
│

113:       
gcp_filestore_csi_driver_config
{
│

│

Blocks of type "gcp_filestore_csi_driver_config" are not expected here.
╵
terraform_validate ./examples/node_pool 
╷
│

Error: 
Unsupported block type
│

│

 on ../../modules/beta-public-cluster/cluster.tf line 164, in resource "google_container_cluster" "primary":
│

164:       
gcp_filestore_csi_driver_config
{
│

│

Blocks of type "gcp_filestore_csi_driver_config" are not expected here.
╵
terraform_validate ./examples/node_pool_update_variant 
╷
│

Error: 
Unsupported block type
│

│

 on ../../modules/private-cluster-update-variant/cluster.tf line 113, in resource "google_container_cluster" "primary":
│

113:       
gcp_filestore_csi_driver_config
{
│

│

Blocks of type "gcp_filestore_csi_driver_config" are not expected here.
╵
terraform_validate ./examples/node_pool_update_variant_beta 
╷
│

Error: 
Unsupported block type
│

│

 on ../../modules/beta-private-cluster-update-variant/cluster.tf line 164, in resource "google_container_cluster" "primary":
│

164:       
gcp_filestore_csi_driver_config
{
│

│

Blocks of type "gcp_filestore_csi_driver_config" are not expected here.
╵
terraform_validate ./examples/node_pool_update_variant_public_beta 
╷
│

Error: 
Unsupported block type
│

│

 on ../../modules/beta-public-cluster-update-variant/cluster.tf line 164, in resource "google_container_cluster" "primary":
│

164:       
gcp_filestore_csi_driver_config
{
│

│

Blocks of type "gcp_filestore_csi_driver_config" are not expected here.
╵
terraform_validate ./examples/private_zonal_with_networking 
╷
│

Error: 
Unsupported block type
│

│

 on ../../modules/private-cluster/cluster.tf line 113, in resource "google_container_cluster" "primary":
│

113:       
gcp_filestore_csi_driver_config
{
│

│

Blocks of type "gcp_filestore_csi_driver_config" are not expected here.
╵
terraform_validate ./examples/regional_private_node_pool_oauth_scopes 
╷
│

Error: 
Unsupported block type
│

│

 on ../../modules/private-cluster/cluster.tf line 113, in resource "google_container_cluster" "primary":
│

113:       
gcp_filestore_csi_driver_config
{
│

│

Blocks of type "gcp_filestore_csi_driver_config" are not expected here.
╵
terraform_validate ./examples/safer_cluster 
╷
│

Error: 
Unsupported block type
│

│

 on ../../modules/beta-private-cluster/cluster.tf line 164, in resource "google_container_cluster" "primary":
│

164:       
gcp_filestore_csi_driver_config
{
│

│

Blocks of type "gcp_filestore_csi_driver_config" are not expected here.
╵
terraform_validate ./examples/safer_cluster_iap_bastion 
╷
│

Error: 
Unsupported block type
│

│

 on ../../modules/beta-private-cluster/cluster.tf line 164, in resource "google_container_cluster" "primary":
│

164:       
gcp_filestore_csi_driver_config
{
│

│

Blocks of type "gcp_filestore_csi_driver_config" are not expected here.
╵
terraform_validate ./examples/shared_vpc 
╷
│

Error: 
Unsupported block type
│

│

 on ../../cluster.tf line 113, in resource "google_container_cluster" "primary":
│

113:       
gcp_filestore_csi_driver_config
{
│

│

Blocks of type "gcp_filestore_csi_driver_config" are not expected here.
╵
terraform_validate ./examples/simple_autopilot_private 
Success!
The configuration is valid.
terraform_validate ./examples/simple_autopilot_public 
Success!
The configuration is valid.
terraform_validate ./examples/simple_regional 
╷
│

Error: 
Unsupported block type
│

│

 on ../../cluster.tf line 113, in resource "google_container_cluster" "primary":
│

113:       
gcp_filestore_csi_driver_config
{
│

│

Blocks of type "gcp_filestore_csi_driver_config" are not expected here.
╵
terraform_validate ./examples/simple_regional_beta 
╷
│

Error: 
Unsupported block type
│

│

 on ../../modules/beta-public-cluster/cluster.tf line 164, in resource "google_container_cluster" "primary":
│

164:       
gcp_filestore_csi_driver_config
{
│

│

Blocks of type "gcp_filestore_csi_driver_config" are not expected here.
╵
terraform_validate ./examples/simple_regional_private 
╷
│

Error: 
Unsupported block type
│

│

 on ../../modules/private-cluster/cluster.tf line 113, in resource "google_container_cluster" "primary":
│

113:       
gcp_filestore_csi_driver_config
{
│

│

Blocks of type "gcp_filestore_csi_driver_config" are not expected here.
╵
terraform_validate ./examples/simple_regional_private_beta 
╷
│

Error: 
Unsupported block type
│

│

 on ../../modules/beta-private-cluster/cluster.tf line 164, in resource "google_container_cluster" "primary":
│

164:       
gcp_filestore_csi_driver_config
{
│

│

Blocks of type "gcp_filestore_csi_driver_config" are not expected here.
╵
terraform_validate ./examples/simple_regional_with_kubeconfig 
╷
│

Error: 
Unsupported block type
│

│

 on ../../cluster.tf line 113, in resource "google_container_cluster" "primary":
│

113:       
gcp_filestore_csi_driver_config
{
│

│

Blocks of type "gcp_filestore_csi_driver_config" are not expected here.
╵
terraform_validate ./examples/simple_regional_with_networking 
╷
│

Error: 
Unsupported block type
│

│

 on ../../cluster.tf line 113, in resource "google_container_cluster" "primary":
│

113:       
gcp_filestore_csi_driver_config
{
│

│

Blocks of type "gcp_filestore_csi_driver_config" are not expected here.
╵
terraform_validate ./examples/simple_zonal_private 
╷
│

Error: 
Unsupported block type
│

│

 on ../../modules/private-cluster/cluster.tf line 113, in resource "google_container_cluster" "primary":
│

113:       
gcp_filestore_csi_driver_config
{
│

│

Blocks of type "gcp_filestore_csi_driver_config" are not expected here.
╵
terraform_validate ./examples/simple_zonal_with_acm 
╷
│

Error: 
Unsupported block type
│

│

 on ../../cluster.tf line 113, in resource "google_container_cluster" "primary":
│

113:       
gcp_filestore_csi_driver_config
{
│

│

Blocks of type "gcp_filestore_csi_driver_config" are not expected here.
╵
terraform_validate ./examples/simple_zonal_with_asm 
╷
│

Error: 
Unsupported block type
│

│

 on ../../cluster.tf line 113, in resource "google_container_cluster" "primary":
│

113:       
gcp_filestore_csi_driver_config
{
│

│

Blocks of type "gcp_filestore_csi_driver_config" are not expected here.
╵
terraform_validate ./examples/simple_zonal_with_hub 
╷
│

Error: 
Unsupported block type
│

│

 on ../../cluster.tf line 113, in resource "google_container_cluster" "primary":
│

113:       
gcp_filestore_csi_driver_config
{
│

│

Blocks of type "gcp_filestore_csi_driver_config" are not expected here.
╵
terraform_validate ./examples/simple_zonal_with_hub_kubeconfig 
Success!
The configuration is valid.
terraform_validate ./examples/stub_domains 
╷
│

Error: 
Unsupported block type
│

│

 on ../../cluster.tf line 113, in resource "google_container_cluster" "primary":
│

113:       
gcp_filestore_csi_driver_config
{
│

│

Blocks of type "gcp_filestore_csi_driver_config" are not expected here.
╵
terraform_validate ./examples/stub_domains_private 
╷
│

Error: 
Unsupported block type
│

│

 on ../../modules/private-cluster/cluster.tf line 113, in resource "google_container_cluster" "primary":
│

113:       
gcp_filestore_csi_driver_config
{
│

│

Blocks of type "gcp_filestore_csi_driver_config" are not expected here.
╵
terraform_validate ./examples/stub_domains_upstream_nameservers 
╷
│

Error: 
Unsupported block type
│

│

 on ../../cluster.tf line 113, in resource "google_container_cluster" "primary":
│

113:       
gcp_filestore_csi_driver_config
{
│

│

Blocks of type "gcp_filestore_csi_driver_config" are not expected here.
╵
terraform_validate ./examples/upstream_nameservers 
╷
│

Error: 
Unsupported block type
│

│

 on ../../cluster.tf line 113, in resource "google_container_cluster" "primary":
│

113:       
gcp_filestore_csi_driver_config
{
│

│

Blocks of type "gcp_filestore_csi_driver_config" are not expected here.
╵
terraform_validate ./examples/workload_identity 
╷
│

Error: 
Unsupported block type
│

│

 on ../../cluster.tf line 113, in resource "google_container_cluster" "primary":
│

113:       
gcp_filestore_csi_driver_config
{
│

│

Blocks of type "gcp_filestore_csi_driver_config" are not expected here.
╵
terraform_validate ./examples/workload_metadata_config 
╷
│

Error: 
Unsupported block type
│

│

 on ../../modules/private-cluster/cluster.tf line 113, in resource "google_container_cluster" "primary":
│

113:       
gcp_filestore_csi_driver_config
{
│

│

Blocks of type "gcp_filestore_csi_driver_config" are not expected here.
╵
terraform_validate ./modules/acm 
Success!
The configuration is valid.
terraform_validate ./modules/asm 
Success!
The configuration is valid.
terraform_validate ./modules/auth 
Success!
The configuration is valid.
terraform_validate ./modules/beta-autopilot-private-cluster 
Success!
The configuration is valid.
terraform_validate ./modules/beta-autopilot-public-cluster 
Success!
The configuration is valid.
terraform_validate ./modules/beta-private-cluster 
╷
│

Error: 
Unsupported block type
│

│

 on cluster.tf line 164, in resource "google_container_cluster" "primary":
│

164:       
gcp_filestore_csi_driver_config
{
│

│

Blocks of type "gcp_filestore_csi_driver_config" are not expected here.
╵
terraform_validate ./modules/beta-private-cluster-update-variant 
╷
│

Error: 
Unsupported block type
│

│

 on cluster.tf line 164, in resource "google_container_cluster" "primary":
│

164:       
gcp_filestore_csi_driver_config
{
│

│

Blocks of type "gcp_filestore_csi_driver_config" are not expected here.
╵
terraform_validate ./modules/beta-public-cluster 
╷
│

Error: 
Unsupported block type
│

│

 on cluster.tf line 164, in resource "google_container_cluster" "primary":
│

164:       
gcp_filestore_csi_driver_config
{
│

│

Blocks of type "gcp_filestore_csi_driver_config" are not expected here.
╵
terraform_validate ./modules/beta-public-cluster-update-variant 
╷
│

Error: 
Unsupported block type
│

│

 on cluster.tf line 164, in resource "google_container_cluster" "primary":
│

164:       
gcp_filestore_csi_driver_config
{
│

│

Blocks of type "gcp_filestore_csi_driver_config" are not expected here.
╵
terraform_validate ./modules/binary-authorization 
Success!
The configuration is valid.
terraform_validate ./modules/config-sync 
Success!
The configuration is valid.
terraform_validate ./modules/hub 
Success!
The configuration is valid.
terraform_validate ./modules/k8s-operator-crd-support 
Success!
The configuration is valid.
terraform_validate ./modules/private-cluster 
╷
│

Error: 
Unsupported block type
│

│

 on cluster.tf line 113, in resource "google_container_cluster" "primary":
│

113:       
gcp_filestore_csi_driver_config
{
│

│

Blocks of type "gcp_filestore_csi_driver_config" are not expected here.
╵
terraform_validate ./modules/private-cluster-update-variant 
╷
│

Error: 
Unsupported block type
│

│

 on cluster.tf line 113, in resource "google_container_cluster" "primary":
│

113:       
gcp_filestore_csi_driver_config
{
│

│

Blocks of type "gcp_filestore_csi_driver_config" are not expected here.
╵
terraform_validate ./modules/safer-cluster 
╷
│

Error: 
Unsupported block type
│

│

 on ../beta-private-cluster/cluster.tf line 164, in resource "google_container_cluster" "primary":
│

164:       
gcp_filestore_csi_driver_config
{
│

│

Blocks of type "gcp_filestore_csi_driver_config" are not expected here.
╵
terraform_validate ./modules/safer-cluster-update-variant 
╷
│

Error: 
Unsupported block type
│

│

 on ../beta-private-cluster-update-variant/cluster.tf line 164, in resource "google_container_cluster" "primary":
│

164:       
gcp_filestore_csi_driver_config
{
│

│

Blocks of type "gcp_filestore_csi_driver_config" are not expected here.
╵
terraform_validate ./modules/services 
Success!
The configuration is valid.
terraform_validate ./modules/workload-identity 
Success!
The configuration is valid.
terraform_validate ./test/fixtures/beta_cluster 
╷
│

Error: 
Unsupported block type
│

│

 on ../../../modules/beta-public-cluster/cluster.tf line 164, in resource "google_container_cluster" "primary":
│

164:       
gcp_filestore_csi_driver_config
{
│

│

Blocks of type "gcp_filestore_csi_driver_config" are not expected here.
╵
terraform_validate ./test/fixtures/deploy_service 
╷
│

Error: 
Unsupported block type
│

│

 on ../../../cluster.tf line 113, in resource "google_container_cluster" "primary":
│

113:       
gcp_filestore_csi_driver_config
{
│

│

Blocks of type "gcp_filestore_csi_driver_config" are not expected here.
╵
terraform_validate ./test/fixtures/disable_client_cert 
╷
│

Error: 
Unsupported block type
│

│

 on ../../../cluster.tf line 113, in resource "google_container_cluster" "primary":
│

113:       
gcp_filestore_csi_driver_config
{
│

│

Blocks of type "gcp_filestore_csi_driver_config" are not expected here.
╵
terraform_validate ./test/fixtures/node_pool 
╷
│

Error: 
Unsupported block type
│

│

 on ../../../modules/beta-public-cluster/cluster.tf line 164, in resource "google_container_cluster" "primary":
│

164:       
gcp_filestore_csi_driver_config
{
│

│

Blocks of type "gcp_filestore_csi_driver_config" are not expected here.
╵
terraform_validate ./test/fixtures/node_pool_update_variant 
╷
│

Error: 
Unsupported block type
│

│

 on ../../../modules/private-cluster-update-variant/cluster.tf line 113, in resource "google_container_cluster" "primary":
│

113:       
gcp_filestore_csi_driver_config
{
│

│

Blocks of type "gcp_filestore_csi_driver_config" are not expected here.
╵
terraform_validate ./test/fixtures/private_zonal_with_networking 
╷
│

Error: 
Unsupported block type
│

│

 on ../../../modules/private-cluster/cluster.tf line 113, in resource "google_container_cluster" "primary":
│

113:       
gcp_filestore_csi_driver_config
{
│

│

Blocks of type "gcp_filestore_csi_driver_config" are not expected here.
╵
terraform_validate ./test/fixtures/safer_cluster 
╷
│

Error: 
Unsupported block type
│

│

 on ../../../modules/beta-private-cluster/cluster.tf line 164, in resource "google_container_cluster" "primary":
│

164:       
gcp_filestore_csi_driver_config
{
│

│

Blocks of type "gcp_filestore_csi_driver_config" are not expected here.
╵
terraform_validate ./test/fixtures/safer_cluster_iap_bastion 
╷
│

Error: 
Unsupported block type
│

│

 on ../../../modules/beta-private-cluster/cluster.tf line 164, in resource "google_container_cluster" "primary":
│

164:       
gcp_filestore_csi_driver_config
{
│

│

Blocks of type "gcp_filestore_csi_driver_config" are not expected here.
╵
terraform_validate ./test/fixtures/sandbox_enabled 
╷
│

Error: 
Unsupported block type
│

│

 on ../../../modules/beta-public-cluster/cluster.tf line 164, in resource "google_container_cluster" "primary":
│

164:       
gcp_filestore_csi_driver_config
{
│

│

Blocks of type "gcp_filestore_csi_driver_config" are not expected here.
╵
terraform_validate ./test/fixtures/simple_autopilot_private 
Success!
The configuration is valid.
terraform_validate ./test/fixtures/simple_autopilot_public 
Success!
The configuration is valid.
terraform_validate ./test/fixtures/simple_regional 
╷
│

Error: 
Unsupported block type
│

│

 on ../../../cluster.tf line 113, in resource "google_container_cluster" "primary":
│

113:       
gcp_filestore_csi_driver_config
{
│

│

Blocks of type "gcp_filestore_csi_driver_config" are not expected here.
╵
terraform_validate ./test/fixtures/simple_regional_private 
╷
│

Error: 
Unsupported block type
│

│

 on ../../../modules/private-cluster/cluster.tf line 113, in resource "google_container_cluster" "primary":
│

113:       
gcp_filestore_csi_driver_config
{
│

│

Blocks of type "gcp_filestore_csi_driver_config" are not expected here.
╵
terraform_validate ./test/fixtures/simple_regional_with_kubeconfig 
╷
│

Error: 
Unsupported block type
│

│

 on ../../../cluster.tf line 113, in resource "google_container_cluster" "primary":
│

113:       
gcp_filestore_csi_driver_config
{
│

│

Blocks of type "gcp_filestore_csi_driver_config" are not expected here.
╵
terraform_validate ./test/fixtures/simple_regional_with_networking 
╷
│

Error: 
Unsupported block type
│

│

 on ../../../cluster.tf line 113, in resource "google_container_cluster" "primary":
│

113:       
gcp_filestore_csi_driver_config
{
│

│

Blocks of type "gcp_filestore_csi_driver_config" are not expected here.
╵
terraform_validate ./test/fixtures/simple_zonal 
╷
│

Error: 
Unsupported block type
│

│

 on ../../../cluster.tf line 113, in resource "google_container_cluster" "primary":
│

113:       
gcp_filestore_csi_driver_config
{
│

│

Blocks of type "gcp_filestore_csi_driver_config" are not expected here.
╵
terraform_validate ./test/fixtures/simple_zonal_private 
╷
│

Error: 
Unsupported block type
│

│

 on ../../../modules/private-cluster/cluster.tf line 113, in resource "google_container_cluster" "primary":
│

113:       
gcp_filestore_csi_driver_config
{
│

│

Blocks of type "gcp_filestore_csi_driver_config" are not expected here.
╵
terraform_validate ./test/fixtures/simple_zonal_with_asm 
╷
│

Error: 
Unsupported block type
│

│

 on ../../../cluster.tf line 113, in resource "google_container_cluster" "primary":
│

113:       
gcp_filestore_csi_driver_config
{
│

│

Blocks of type "gcp_filestore_csi_driver_config" are not expected here.
╵
terraform_validate ./test/fixtures/stub_domains 
╷
│

Error: 
Unsupported block type
│

│

 on ../../../cluster.tf line 113, in resource "google_container_cluster" "primary":
│

113:       
gcp_filestore_csi_driver_config
{
│

│

Blocks of type "gcp_filestore_csi_driver_config" are not expected here.
╵
terraform_validate ./test/fixtures/stub_domains_private 
╷
│

Error: 
Unsupported block type
│

│

 on ../../../modules/private-cluster/cluster.tf line 113, in resource "google_container_cluster" "primary":
│

113:       
gcp_filestore_csi_driver_config
{
│

│

Blocks of type "gcp_filestore_csi_driver_config" are not expected here.
╵
terraform_validate ./test/fixtures/stub_domains_upstream_nameservers 
╷
│

Error: 
Unsupported block type
│

│

 on ../../../cluster.tf line 113, in resource "google_container_cluster" "primary":
│

113:       
gcp_filestore_csi_driver_config
{
│

│

Blocks of type "gcp_filestore_csi_driver_config" are not expected here.
╵
terraform_validate ./test/fixtures/upstream_nameservers 
╷
│

Error: 
Unsupported block type
│

│

 on ../../../cluster.tf line 113, in resource "google_container_cluster" "primary":
│

113:       
gcp_filestore_csi_driver_config
{
│

│

Blocks of type "gcp_filestore_csi_driver_config" are not expected here.
╵
terraform_validate ./test/fixtures/workload_identity 
╷
│

Error: 
Unsupported block type
│

│

 on ../../../cluster.tf line 113, in resource "google_container_cluster" "primary":
│

113:       
gcp_filestore_csi_driver_config
{
│

│

Blocks of type "gcp_filestore_csi_driver_config" are not expected here.
╵
terraform_validate ./test/fixtures/workload_metadata_config 
╷
│

Error: 
Unsupported block type
│

│

 on ../../../modules/private-cluster/cluster.tf line 113, in resource "google_container_cluster" "primary":
│

113:       
gcp_filestore_csi_driver_config
{
│

│

Blocks of type "gcp_filestore_csi_driver_config" are not expected here.
╵
terraform_validate ./test/setup 
Success!
The configuration is valid.

bharathkkb

@davidspek thanks for working on this! The error should be fixed in #1159

davidspek · 2022-03-02T23:28:55Z

@bharathkkb should I rebase on that PR?

bharathkkb · 2022-03-02T23:53:55Z

@davidspek so it was actually fixed in #1148 which was merged to main. If you could rebase on main that would be great

Signed-off-by: DavidSpek <[email protected]>

davidspek · 2022-03-03T10:08:02Z

@bharathkkb Just rebased it again, let's see what the CI does.

bharathkkb

Thanks for rebasing @davidspek
A few comments below and could you run make build to regenerate?

bharathkkb · 2022-03-03T23:11:34Z

autogen/main/cluster.tf.tmpl

@@ -185,6 +185,11 @@ resource "google_container_cluster" "primary" {
    horizontal_pod_autoscaling {
      disabled = !var.horizontal_pod_autoscaling
    }
+
+    gcp_filestore_csi_driver_config {


I see a conflit with autopilot, so we will need to move this into the % if autopilot_cluster != true %} block

https://github.com/hashicorp/terraform-provider-google/blob/d3ab68df17134e96ad8f14548a1f68f45a0eeae1/google/resource_container_cluster.go#L239

bharathkkb · 2022-03-03T23:12:00Z

autogen/main/main.tf.tmpl

@@ -186,6 +186,7 @@ locals {
  cluster_http_load_balancing_enabled        = ! local.cluster_output_http_load_balancing_enabled
  cluster_horizontal_pod_autoscaling_enabled = ! local.cluster_output_horizontal_pod_autoscaling_enabled
  workload_identity_enabled                  = ! (var.identity_namespace == null || var.identity_namespace == "null")
+  cluster_filestore_csi_driver_config        = var.filestore_csi_driver


I noticed that this looks unused?

davidspek · 2022-03-04T16:35:43Z

@bharathkkb I think the changes I've just pushed resolve your comments. My familiarity with this code base isn't great, since all I really did was rebase the original PR. If it still doesn't look good I'll dive into it deeper.

bharathkkb · 2022-03-04T23:15:56Z

@davidspek no problem, I was trying to push to your branch but looks like I dont have access. I will open a PR with the fixes.

davidspek · 2022-03-05T08:43:27Z

@bharathkkb Thanks for jumping on this!

davidspek requested review from a team, Jberlinsky and bharathkkb as code owners February 24, 2022 19:23

davidspek force-pushed the filestore-csi branch from f82cb9c to 75d551d Compare February 24, 2022 19:24

davidspek mentioned this pull request Feb 24, 2022

feat: add gcp_filestore_csi_driver_config to addons config #1145

Closed

bharathkkb approved these changes Feb 24, 2022

View reviewed changes

feat: add gcp_filestore_csi_driver_config to addons config

94dbe4b

Signed-off-by: DavidSpek <[email protected]>

davidspek force-pushed the filestore-csi branch from 75d551d to 94dbe4b Compare March 3, 2022 10:07

bharathkkb reviewed Mar 3, 2022

View reviewed changes

suggested changes

d7fbf3c

bharathkkb mentioned this pull request Mar 4, 2022

feat!: add gcp_filestore_csi_driver_config to addons config #1166

Merged

morgante closed this Mar 8, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: add gcp_filestore_csi_driver_config to addons config #1161

feat: add gcp_filestore_csi_driver_config to addons config #1161

Uh oh!

davidspek commented Feb 24, 2022

Uh oh!

davidspek commented Feb 24, 2022

Uh oh!

comment-bot-dev commented Feb 24, 2022 •

edited

Loading

Uh oh!

bharathkkb left a comment

Uh oh!

davidspek commented Mar 2, 2022

Uh oh!

bharathkkb commented Mar 2, 2022

Uh oh!

davidspek commented Mar 3, 2022

Uh oh!

bharathkkb left a comment

Uh oh!

bharathkkb Mar 3, 2022

Uh oh!

bharathkkb Mar 3, 2022

Uh oh!

davidspek commented Mar 4, 2022

Uh oh!

bharathkkb commented Mar 4, 2022

Uh oh!

davidspek commented Mar 5, 2022

Uh oh!

Uh oh!

feat: add gcp_filestore_csi_driver_config to addons config #1161

feat: add gcp_filestore_csi_driver_config to addons config #1161

Uh oh!

Conversation

davidspek commented Feb 24, 2022

Uh oh!

davidspek commented Feb 24, 2022

Uh oh!

comment-bot-dev commented Feb 24, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bharathkkb left a comment

Choose a reason for hiding this comment

Uh oh!

davidspek commented Mar 2, 2022

Uh oh!

bharathkkb commented Mar 2, 2022

Uh oh!

davidspek commented Mar 3, 2022

Uh oh!

bharathkkb left a comment

Choose a reason for hiding this comment

Uh oh!

bharathkkb Mar 3, 2022

Choose a reason for hiding this comment

Uh oh!

bharathkkb Mar 3, 2022

Choose a reason for hiding this comment

Uh oh!

davidspek commented Mar 4, 2022

Uh oh!

bharathkkb commented Mar 4, 2022

Uh oh!

davidspek commented Mar 5, 2022

Uh oh!

Uh oh!

comment-bot-dev commented Feb 24, 2022 •

edited

Loading