Skip to content

Add keeper for enable_secure_boot nodepool option for update variant. #1277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 2, 2022

Conversation

fbeevikm
Copy link
Contributor

As changing the enable_secure_boot config currently forces a replacement of
the node pool, see:
https://github.com/hashicorp/terraform-provider-google/blob/5290a9f74d491bd3a05c32cdc60773ac6c53d4ae/google/node_config.go#L217

Fixes #1276

@comment-bot-dev
Copy link

Thanks for the PR! 🚀
✅ Lint checks have passed.

Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @fbeevikm

@bharathkkb bharathkkb merged commit a8b6f20 into terraform-google-modules:master Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

beta-private-cluster-update-variant should generate new node pool ID if nodepools.enable_secure_boot value is changed
3 participants