feat:add support for provisioning windows node pools #1402
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
g-awmalik
requested review from
a team,
Jberlinsky and
bharathkkb
as code owners
|
@bharathkkb - PTAL? |
bharathkkb
approved these changes
Sep 16, 2022
bharathkkb
reviewed
Sep 19, 2022
Comment on lines
38
to
52
| ip_range_pods = var.ip_range_pods | ||
| ip_range_services = var.ip_range_services | ||
| create_service_account = var.compute_engine_service_account == "create" | ||
| service_account = var.compute_engine_service_account | ||
| istio = var.istio | ||
| cloudrun = var.cloudrun | ||
| dns_cache = var.dns_cache | ||
| gce_pd_csi_driver = var.gce_pd_csi_driver | ||
| sandbox_enabled = var.sandbox_enabled | ||
| database_encryption = var.database_encryption | ||
| enable_binary_authorization = var.enable_binary_authorization | ||
| enable_pod_security_policy = var.enable_pod_security_policy | ||
| enable_identity_service = true | ||
| release_channel = "REGULAR" | ||
| logging_enabled_components = ["SYSTEM_COMPONENTS"] |
There was a problem hiding this comment.
Let's hardcode most of these. Ideally only project ID is needed as input which we will pass in via fixture.
| upper = false | ||
| } | ||
|
|
||
| resource "google_compute_network" "main" { |
There was a problem hiding this comment.
We can move this to examples with fixtures being a thin wrapper around examples.
|
@g-awmalik |
|
@bharathkkb - can you take one more look? I want to release this soon. Thanks! |
bharathkkb
approved these changes
Sep 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1383
Tested with
windows_node_poolsto an existing clusternode_poolsand 1windows_node_poolswindows_node_poolsto an existing cluster with 2node_pools(one windows based and one linux based)Additionally, it doesn't cause breaking changes to existing plans.