Skip to content

feat: add beta multi networking options #1829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

dzoeteman
Copy link

Add beta multi-networking options.
This is lightly based on the work in #1721, but that PR was closed due to inactivity.

  • Implemented in autogen template
  • Had to always include network_config block on the node pool due to otherwise too complicated if statement depending on beta cluster or not; this should be fine anyway with the defaults of the option in the block.
  • Tested on GCP.

@dzoeteman dzoeteman requested review from ericyz and a team as code owners December 23, 2023 04:38
@dzoeteman
Copy link
Author

@apeabody Hi, could I ask for a /gcbrun ? Happy to update branch as well 🙇

@apeabody
Copy link
Collaborator

/gcbrun

Copy link

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the Stale label Mar 19, 2024
@github-actions github-actions bot closed this Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants