Skip to content

chore: add island-cluster example #1918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

nvnmandadhi
Copy link
Contributor

@nvnmandadhi nvnmandadhi commented Apr 1, 2024

This PR adds an example to create an island-cluster, this allows reusing the same IP address space for multiple clusters in a single project.

@nvnmandadhi nvnmandadhi requested review from ericyz, gtsorbo and a team as code owners April 1, 2024 15:47
@nvnmandadhi nvnmandadhi force-pushed the island-cluster-submodule branch from 4d58cad to a1793cd Compare April 1, 2024 15:51
@gtsorbo
Copy link
Contributor

gtsorbo commented Apr 2, 2024

/gcbrun

@gtsorbo gtsorbo changed the title add island-cluster submodule and an example feat: add island-cluster submodule and an example Apr 2, 2024
Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @nvnmandadhi

@nvnmandadhi nvnmandadhi force-pushed the island-cluster-submodule branch from a1793cd to 8402f09 Compare April 3, 2024 20:47
@nvnmandadhi nvnmandadhi requested a review from bharathkkb April 3, 2024 20:48
@nvnmandadhi nvnmandadhi changed the title feat: add island-cluster submodule and an example feat: add island-cluster example Apr 3, 2024
@nvnmandadhi nvnmandadhi force-pushed the island-cluster-submodule branch from 8402f09 to 27ce085 Compare April 3, 2024 20:55
@nvnmandadhi nvnmandadhi force-pushed the island-cluster-submodule branch 5 times, most recently from ada94b7 to 9c98e48 Compare April 4, 2024 16:50
@nvnmandadhi nvnmandadhi requested a review from bharathkkb April 4, 2024 16:53
@nvnmandadhi nvnmandadhi force-pushed the island-cluster-submodule branch from 9c98e48 to 31c5f2f Compare April 4, 2024 16:56
@bharathkkb bharathkkb changed the title feat: add island-cluster example chore: add island-cluster example Apr 4, 2024
@bharathkkb bharathkkb merged commit e711adb into terraform-google-modules:master Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants