-
Notifications
You must be signed in to change notification settings - Fork 1.2k
chore: update example module sources and versions #2116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update example module sources and versions #2116
Conversation
- Update module source. This should prevent the source from getting rewritten when tests are run locally - Add missing version spec to match other modules
/gcbrun |
@@ -33,7 +33,9 @@ provider "kubernetes" { | |||
} | |||
|
|||
module "gke" { | |||
source = "../../modules/beta-autopilot-private-cluster/" | |||
source = "terraform-google-modules/kubernetes-engine/google//modules/beta-autopilot-private-cluster/" | |||
version = "~> 33.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure why lint is complaining about this one, unless it was from the previous push?
Co-authored-by: Andrew Peabody <[email protected]>
/gcbrun |
/gcbrun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @wyardley!
@apeabody ack, another flake maybe? |
Yup, slow API activation |
Follow-up to #2115 (comment)
For example this:
gets rewritten like this when the docker test / lint make target is run.