Skip to content

chore: update example module sources and versions #2116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

wyardley
Copy link
Contributor

@wyardley wyardley commented Sep 25, 2024

  • Update module source. This should prevent the source from getting rewritten when tests are run locally
  • Add missing version spec to match other modules

Follow-up to #2115 (comment)

For example this:

module "permissions" {
  source = "../../modules/fleet-app-operator-permissions"
  # also no version specification here
}

gets rewritten like this when the docker test / lint make target is run.

--- a/examples/autopilot_private_firewalls/main.tf
+++ b/examples/autopilot_private_firewalls/main.tf
@@ -33,7 +33,7 @@ provider "kubernetes" {
 }
 
 module "gke" {
-  source                            = "../../modules/beta-autopilot-private-cluster/"
+  source                            = "wyardley/kubernetes-engine/google//modules/beta-autopilot-private-cluster"
   project_id                        = var.project_id
   name                              = "${local.cluster_type}-cluster"
   regional                          = true

- Update module source. This should prevent the source from getting
  rewritten when tests are run locally
- Add missing version spec to match other modules
@wyardley wyardley requested review from ericyz, gtsorbo and a team as code owners September 25, 2024 19:33
@apeabody
Copy link
Collaborator

/gcbrun

@@ -33,7 +33,9 @@ provider "kubernetes" {
}

module "gke" {
source = "../../modules/beta-autopilot-private-cluster/"
source = "terraform-google-modules/kubernetes-engine/google//modules/beta-autopilot-private-cluster/"
version = "~> 33.0"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure why lint is complaining about this one, unless it was from the previous push?

Co-authored-by: Andrew Peabody <[email protected]>
@apeabody
Copy link
Collaborator

/gcbrun

@apeabody
Copy link
Collaborator

/gcbrun

Copy link
Collaborator

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @wyardley!

@apeabody apeabody enabled auto-merge (squash) September 25, 2024 20:56
@wyardley
Copy link
Contributor Author

@apeabody ack, another flake maybe?

@apeabody
Copy link
Collaborator

@apeabody ack, another flake maybe?

Yup, slow API activation

@apeabody apeabody merged commit 51ed882 into terraform-google-modules:master Sep 25, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants