Feature/collapse regional and zonal clusters #223
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ingwarr
suggested changes
Aug 5, 2019
ingwarr
suggested changes
Aug 6, 2019
ivankorn
reviewed
Aug 8, 2019
ivankorn
reviewed
Aug 8, 2019
ivankorn
previously approved these changes
Aug 8, 2019
ingwarr
previously approved these changes
Aug 8, 2019
kopachevsky
requested review from
aaron-lane,
adrienthebo,
Jberlinsky and
morgante
as code owners
morgante
suggested changes
Aug 14, 2019
|
@kopachevsky Please resolve merge conflicts. |
ivankorn
previously approved these changes
Aug 14, 2019
ingwarr
previously approved these changes
Aug 14, 2019
morgante
suggested changes
Aug 14, 2019
morgante
suggested changes
Aug 14, 2019
kopachevsky
commented
Aug 14, 2019
Collapsed regional and zonal clusters into one cluster with location attribute instead usage of count, zones and regions.
Selection of latest nodes and master version same both for regional and zonal/multi-zonal clusters.
For Master version in case or regional cluster following code check latest version by location (region),
and for zonal, location is var.zone[0]:
latest_master_version = data.google_container_engine_versions.master.latest_master_version
For Node version in case of regional cluster used latest master version of first of available zones, and in case of
zonal cluster - latest master version of var.zones[0] zone
location = local.zone_count == 0 ? data.google_compute_zones.available.names[0] : var.zones[0]
Fixes #161
|
@morgante I've tested locally, tests passed except 2 stub_domains_* ones, it's not possible to test them locallly. Please review. |
morgante
approved these changes
Aug 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor/flatten duplicate resources #161