Changed region variable
#247
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulpalamarchuk
force-pushed
the
region_var_became_optional
branch
from
9818725 to
6acf099
Compare
paulpalamarchuk
requested review from
ingwarr,
ivankorn,
kopachevsky and
nick4fake
ingwarr
previously approved these changes
Aug 27, 2019
kopachevsky
reviewed
Sep 4, 2019
ivankorn
previously approved these changes
Sep 9, 2019
paulpalamarchuk
requested review from
aaron-lane,
adrienthebo,
Jberlinsky and
morgante
as code owners
aaron-lane
suggested changes
Sep 10, 2019
paulpalamarchuk
dismissed stale reviews from ivankorn and ingwarr
via
f692693
paulpalamarchuk
force-pushed
the
region_var_became_optional
branch
from
6acf099 to
f692693
Compare
kopachevsky
previously approved these changes
Sep 11, 2019
aaron-lane
previously requested changes
Sep 24, 2019
paulpalamarchuk
force-pushed
the
region_var_became_optional
branch
from
f692693 to
4344b0a
Compare
Jberlinsky
previously requested changes
Oct 7, 2019
paulpalamarchuk
force-pushed
the
region_var_became_optional
branch
from
4344b0a to
3f0cf1b
Compare
|
Please fix any Cloud Build issues. Terraform lint issues should be addressed in the autogen directory so that the generated files do not require changes. |
* `region` variable became optional for zonal clusters (Fixes terraform-google-modules#235)
paulpalamarchuk
force-pushed
the
region_var_became_optional
branch
from
08440ed to
c4bf4cf
Compare
kopachevsky
previously approved these changes
Oct 14, 2019
|
Approved when cloud build is green |
morgante
approved these changes
Oct 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
regionvariable became optional for zonal clusters (Fixes Region variable should be optional for zonal clusters #235)