Update test to run all #275
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulpalamarchuk
force-pushed
the
fix_ci_tests_node_pool_deploy_service
branch
11 times, most recently
from
377eeef to
59e0c7e
Compare
paulpalamarchuk
force-pushed
the
fix_ci_tests_node_pool_deploy_service
branch
from
59e0c7e to
9f8f3a9
Compare
paulpalamarchuk
force-pushed
the
fix_ci_tests_node_pool_deploy_service
branch
2 times, most recently
from
f2834a5 to
486d6bd
Compare
kopachevsky
reviewed
Oct 16, 2019
paulpalamarchuk
force-pushed
the
fix_ci_tests_node_pool_deploy_service
branch
12 times, most recently
from
321aa78 to
80b43b6
Compare
paulpalamarchuk
force-pushed
the
fix_ci_tests_node_pool_deploy_service
branch
from
a922bf0 to
6b4f36d
Compare
paulpalamarchuk
force-pushed
the
fix_ci_tests_node_pool_deploy_service
branch
from
6b4f36d to
3906c7b
Compare
aaron-lane
suggested changes
Oct 28, 2019
There was a problem hiding this comment.
Thanks @paulpalamarchuk!
The only outstanding ask is to add steps to int.cloudbuild.yaml for deploy-service-local and node-pool-local as the configuration was parallelized in #292 to reduce testing time.
paulpalamarchuk
force-pushed
the
fix_ci_tests_node_pool_deploy_service
branch
from
a07548d to
eadb54a
Compare
morgante
previously approved these changes
Oct 30, 2019
morgante
previously approved these changes
Oct 30, 2019
|
@paulpalamarchuk Please make sure Cloud Build tests pass, you might need to rebase on master. |
paulpalamarchuk
force-pushed
the
fix_ci_tests_node_pool_deploy_service
branch
9 times, most recently
from
2c40a29 to
a1d2c6f
Compare
|
@aaron-lane PTAL |
paulpalamarchuk
force-pushed
the
fix_ci_tests_node_pool_deploy_service
branch
from
7af95f0 to
ee379fa
Compare
paulpalamarchuk
force-pushed
the
fix_ci_tests_node_pool_deploy_service
branch
from
ee379fa to
ccaa36c
Compare
aaron-lane
approved these changes
Nov 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
deploy_serviceandnode_poolfail verification on CI #274