Updated dev tools docker image tag to 0.4.6 #289
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulpalamarchuk
force-pushed
the
update_devtools_img_tag_to_0.4.3
branch
2 times, most recently
from
f59d79f to
764f033
Compare
|
This was partially addressed by #292 which updated the image to 0.4.5. |
nick4fake
suggested changes
Oct 24, 2019
| @@ -15,6 +15,11 @@ | |||
|
|
|||
| set -e | |||
|
|
|||
| # shellcheck disable=SC2034 | |||
| if [ -n "${GOOGLE_APPLICATION_CREDENTIALS}" ]; then | |||
| CLOUDSDK_AUTH_CREDENTIAL_FILE_OVERRIDE=${GOOGLE_APPLICATION_CREDENTIALS} | |||
| @@ -34,6 +34,7 @@ resource "random_shuffle" "available_zones" { | |||
| locals { | |||
| // location | |||
| location = var.regional ? var.region : var.zones[0] | |||
| region = var.region == null ? join("-", slice(split("-", var.zones[0]), 0, 2)) : var.region | |||
There was a problem hiding this comment.
Are you sure it is safe?
| variable "registry_project_id" { | ||
| type = string | ||
| description = "Project holding the Google Container Registry. If empty, we use the cluster project. If grant_registry_access is true, storage.objectViewer role is assigned on this project." | ||
| default = "" |
There was a problem hiding this comment.
Why do you have empty line as a default?
| @@ -15,6 +15,11 @@ | |||
|
|
|||
| set -e | |||
|
|
|||
| # shellcheck disable=SC2034 | |||
| if [ -n "${GOOGLE_APPLICATION_CREDENTIALS}" ]; then | |||
| CLOUDSDK_AUTH_CREDENTIAL_FILE_OVERRIDE=${GOOGLE_APPLICATION_CREDENTIALS} | |||
| variable "registry_project_id" { | ||
| type = string | ||
| description = "Project holding the Google Container Registry. If empty, we use the cluster project. If grant_registry_access is true, storage.objectViewer role is assigned on this project." | ||
| default = "" |
paulpalamarchuk
force-pushed
the
update_devtools_img_tag_to_0.4.3
branch
from
764f033 to
4531f0d
Compare
* Fixed lint tests * Updated Makefile * Fixed check_generate test function
paulpalamarchuk
force-pushed
the
update_devtools_img_tag_to_0.4.3
branch
from
4531f0d to
40a08a0
Compare
paulpalamarchuk
changed the title
|
PR rebased |
nick4fake
approved these changes
Oct 28, 2019
paulpalamarchuk
requested review from
aaron-lane,
adrienthebo,
Jberlinsky and
morgante
as code owners
morgante
approved these changes
Oct 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.