Don't attempt to set node_locations on pools if unspecified #327
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morgante
requested review from
aaron-lane,
adrienthebo and
Jberlinsky
as code owners
morgante
force-pushed
the
bugfix/node_locations
branch
from
e37f0fc to
efa4b61
Compare
bharathkkb
approved these changes
Nov 15, 2019
|
(Destroy error in CI is spurious.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #326 by simply setting node_locations to
nullif they're not specified on the individual node pool. This should be closer to the default provider behavior and reduce spurious diffs.