Skip to content

Remove file function wrapper from ssh_auth_key variable #577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 25, 2020
Merged

Conversation

dpatrick
Copy link
Contributor

Fixes #576

I looked back at the git history and found this regression was introduced when the config sync module was added, though it applies to the acm module as well.

@dpatrick dpatrick requested review from bharathkkb, Jberlinsky and a team as code owners June 23, 2020 18:38
@bharathkkb
Copy link
Member

@morgante do you know what those extra triggers are? I see that in the main build too where both int and lint are green.

Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! 🚀
I think we should also update the description for

@morgante morgante merged commit d1c3c13 into terraform-google-modules:master Jun 25, 2020
@morgante
Copy link
Contributor

@morgante do you know what those extra triggers are? I see that in the main build too where both int and lint are green.

It's the same triggers, but it looks like Cloud Build has yet again chained the names they send back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to use terraform data resource as ssh_auth_key value
3 participants