Skip to content

fix: Fix skip_provisioners enabled flag for wait_for_cluster #669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 15, 2020
Merged

fix: Fix skip_provisioners enabled flag for wait_for_cluster #669

merged 4 commits into from
Sep 15, 2020

Conversation

bharathkkb
Copy link
Member

IIUC we should set enabled = false when skip_provisioners = true. Looks like a regression from #404

@bharathkkb bharathkkb requested review from Jberlinsky and a team as code owners September 14, 2020 21:01
@comment-bot-dev
Copy link

comment-bot-dev commented Sep 14, 2020 •
edited
Loading

Thanks for the PR! 🚀
✅ Lint checks have passed.

@bharathkkb
Copy link
Member Author

also fixes cloud run int tests due to API change ref: b/159766801

@bharathkkb bharathkkb merged commit e293a43 into master Sep 15, 2020
@bharathkkb bharathkkb deleted the fix-skip-provisioners branch September 15, 2020 01:41
@bharathkkb bharathkkb mentioned this pull request Sep 15, 2020
Closed
This was referenced Oct 14, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morgante morgante morgante approved these changes

@Jberlinsky Jberlinsky Awaiting requested review from Jberlinsky

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bharathkkb @comment-bot-dev @morgante