Skip to content

Promote previously beta features to GA modules #709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 14, 2020
Merged

Promote previously beta features to GA modules #709

merged 5 commits into from
Oct 14, 2020

Conversation

marko7460
Copy link
Contributor

This PR fixes #644

@marko7460 marko7460 requested review from bharathkkb, Jberlinsky and a team as code owners October 10, 2020 01:28
@comment-bot-dev
Copy link

comment-bot-dev commented Oct 10, 2020 •
edited
Loading

Thanks for the PR! 🚀
✅ Lint checks have passed.

@marko7460 marko7460 mentioned this pull request Oct 10, 2020
Closed
bharathkkb
bharathkkb reviewed Oct 12, 2020
View reviewed changes
Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM
Can we implement swap a couple of checks as described #706 (review) ?

@marko7460
fix: promoting release_channel, database_encryption, workload_identit…
0b9fcd4 
…y_config, and enable_shielded_nodes from beta to GA
@marko7460
Copy link
Contributor Author

@bharathkkb I have missed to update the source in examples/node_pool. All other non beta examples have been updated to point to non beta modules including workload identity. Maybe I'm not understanding the task. Are there other examples that need updating?

marko7460
marko7460 commented Oct 12, 2020
View reviewed changes
bharathkkb
bharathkkb approved these changes Oct 14, 2020
View reviewed changes
Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bharathkkb bharathkkb merged commit 2cb4fae into terraform-google-modules:master Oct 14, 2020
@bharathkkb bharathkkb mentioned this pull request Oct 15, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bharathkkb bharathkkb bharathkkb approved these changes

@Jberlinsky Jberlinsky Awaiting requested review from Jberlinsky

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Promote previously beta features to GA modules
4 participants
@marko7460 @comment-bot-dev @bharathkkb @MeNsaaH