Skip to content

Adding the code for Part3 of the ACM GKE blog - enabling Config Connector and initializing GCP resources #980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 35 commits into from
Sep 2, 2021
Merged

Adding the code for Part3 of the ACM GKE blog - enabling Config Connector and initializing GCP resources #980

merged 35 commits into from
Sep 2, 2021

Conversation

AlexBulankou
Copy link
Contributor

No description provided.

@AlexBulankou AlexBulankou requested review from bharathkkb, Jberlinsky and a team as code owners August 19, 2021 19:18
@comment-bot-dev
Copy link

comment-bot-dev commented Aug 19, 2021 •
edited
Loading

Thanks for the PR! 🚀
✅ Lint checks have passed.

@morgante
Copy link
Contributor

@AlexBulankou Please fix the formatting. ^^^

@AlexBulankou
Copy link
Contributor Author

@morgante , thanks. Fixed the trailing whitespace, YAML hearers are there, but not detected currently by the checks.

@morgante morgante mentioned this pull request Aug 21, 2021
Closed
morgante
morgante reviewed Aug 21, 2021
View reviewed changes
Copy link
Contributor

@morgante morgante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a few nits / suggestions for the documentation, though they don't need to block.

AlexBulankou and others added 8 commits August 23, 2021 14:30
@AlexBulankou
Copy link
Contributor Author

@morgante , thanks for the review. Addressed the comments.

@AlexBulankou
Copy link
Contributor Author

One of the checks continues to fail, but I don't think it is related to my change.

Finished Step #37 - "verify stub-domains-upstream-nameservers-local"
ERROR: build step 37 "gcr.io/cloud-foundation-cicd/cft/developer-tools:1.0" failed: step exited with non-zero status: 20
Step #24 - "converge simple-zonal-local":        module.example.module.acm.module.acm_operator.module.wait_for_gatekeeper.module.gcloud_kubectl.null_resource.run_command[0] (local-exec): Waiting for deployment gatekeeper-controller-manager in cluster gke_ci-gke-5041ebf3-f600_us-central1-a_simple-zonal-cluster-wm7y to be created...

@bharathkkb , @morgante , can you please review and merge?

@morgante
Copy link
Contributor

@AlexBulankou It looks like some of my comments were still unaddressed. Ex. #980 (comment)

@AlexBulankou
Copy link
Contributor Author

@AlexBulankou It looks like some of my comments were still unaddressed. Ex. #980 (comment)

Yes, missed that comment. Let me fix it first.

@AlexBulankou AlexBulankou requested a review from morgante August 30, 2021 00:08
morgante
morgante approved these changes Sep 2, 2021
View reviewed changes
@morgante morgante merged commit bc41a98 into terraform-google-modules:master Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andudo andudo andudo left review comments

@morgante morgante morgante approved these changes

@bharathkkb bharathkkb Awaiting requested review from bharathkkb

@Jberlinsky Jberlinsky Awaiting requested review from Jberlinsky

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AlexBulankou @comment-bot-dev @morgante @andudo