Add google_disabled_api rule #75
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2
This PR enables deep checking for the Google provider. As a feature of the deep checking, I will add the
google_disabled_api
rule that finds resources that depend on APIs that have not been enabled using the Service Usage API.The correspondence between Terraform resources and API uses the products file generated from the Magic Module. See also terraform-linters/magic-modules#1
To enable this rule, change the plugin definition to enable deep checking as follows:
I'm using the Service Usage API to get API status, but I'm wondering if this is the best option. In order to take advantage of this rule, you need to enable the Service Usage API, so it might be better to implement a rule for each resource and call an API in each rule.
TODO