build: ease integration into projects

[shaman-apprentice]

close #333

Thanks for being open to this change. Please let me know, if I have missed something. But I think this is the only necessary change.

[timdeschryver]

We still want to register rxjs as a peer dep.
But, we also want to support v6

Suggested change

	"@angular/core": ">= 14.0.0"
	"@angular/core": ">= 14.0.0",
	"rxjs": "^6.5.3 || ^7.4.0"

[shaman-apprentice]

I think that would work for me.

I couldn't find any usage of rxjs in the library code itself. Would something not work as expected, if someone installed the library and doesn't provide rxjs? If not I would like to free the user of the obligation to install rxjs. What do you think?

[timdeschryver]

Oh! That's a very good point 😅 I'm so used to having it as a peer dep, but you're right we can just remove it here.
We also don't need it in the dev deps, because that's being handled at the root level.

[shaman-apprentice]

I am glad I didn't miss anything. Thanks for checking and responding so fast! 🙂 I updated the PR and removed it from dev deps as well.

[timdeschryver]

Thanks!

[timdeschryver]

@all-contributors please add @shaman-apprentice for maintenance

[allcontributors]

@timdeschryver

I've put up a pull request to add @shaman-apprentice! 🎉

[github-actions]

🎉 This PR is included in version 12.2.1 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[dzonatan]

@timdeschryver I don't understand how.. but this somehow got messed up during release.
12.2.1 still holds rxjs peer dependency (strictly to 7.5.6 which produces even more warnings when resolving dependencies).

❯ npm info @testing-library/[email protected] peerDependencies
{
  '@angular/common': '>= 14.0.0',
  '@angular/platform-browser': '>= 14.0.0',
  '@angular/router': '>= 14.0.0',
  '@angular/core': '>= 14.0.0',
  rxjs: '7.5.6'
}

❯ npm info @testing-library/[email protected] peerDependencies
{
  '@angular/common': '>= 14.0.0',
  '@angular/platform-browser': '>= 14.0.0',
  '@angular/router': '>= 14.0.0',
  '@angular/core': '>= 14.0.0',
  rxjs: '>= 7.4.0'
}

[timdeschryver]

@dzonatan it's some NX magic.
This commit should resolve that 65cccbe

[timdeschryver]

Seems to be resolved now, thanks for the follow up @dzonatan !
https://unpkg.com/@testing-library/[email protected]/package.json