Skip to content

Release Beta #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 12, 2020
Merged

Release Beta #122

merged 4 commits into from
Mar 12, 2020

Conversation

kentcdodds
Copy link
Member

What: Release the beta branch

Why: To drop node 8 and update to the latest of @testing-library/dom

How: Simple changes

Checklist:

  • Documentation N/A
  • Tests N/A
  • Ready to be merged

.gitignore Outdated
Comment on lines 10 to 13

# cypress recordings during a test run are temporary files
/cypress/videos/
/cypress/screenshots/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

NicholasBoll
NicholasBoll previously approved these changes Mar 5, 2020
package.json Outdated
"license": "MIT",
"dependencies": {
"@babel/runtime": "^7.8.4",
"@testing-library/dom": "^6.15.0",
"@testing-library/dom": "beta",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious what this will do? This is being merged into master, but uses the beta npm tag for @testing-library/dom?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll make sure to update this when the beta is stable before we merge this 👍

@kentcdodds
Copy link
Member Author

I'm preparing to release the beta of @testing-library/dom tomorrow. After that I'll merge this one as well. Anyone else have breaking changes we should make before doing that? @testing-library/cypress

@NicholasBoll
Copy link
Contributor

Perhaps removing query* queries entirely?

@kentcdodds
Copy link
Member Author

I'm actually ok with that. Should we just ditch the idea of deprecation messages?

@NicholasBoll
Copy link
Contributor

I fixed the deprecation PR. It was a change to chai around deep vs nested

@NicholasBoll
Copy link
Contributor

Also fallback of previous subject introduced by b58f747 as part of #108

BREAKING CHANGE: This updates @testing-library/dom, please check the changelog for the most recent version of that package to know whether you are impacted by these changes.
Closes #113

BREAKING CHANGE: Node 10 or greater is now required to use this package
kentcdodds and others added 2 commits March 12, 2020 17:20
BREAKING CHANGE: Remove `query*` queries. Throw an error instead. Fixing requires updating all `query*` to `find*` queries. In practice this means replacing `cy.query` with `cy.find`

BREAKING CHANGE: Remove fallback that retries chaiined query that assumes no previous subject. In practice this means starting new chains if no previous subject is required.

```js
// Before
cy.findByText('Foo')
  .click()
  .findByText('Bar') // Element with 'Bar' text is not a child of an element with 'Foo' text
  .click()
// After
cy.findByText('Foo')
  .click()
cy.findByText('Bar')
  .click()
```
@kentcdodds kentcdodds merged commit ee75c14 into master Mar 12, 2020
@kentcdodds kentcdodds deleted the beta branch March 12, 2020 23:23
@kentcdodds
Copy link
Member Author

🎉 This PR is included in version 6.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants