feat(alt-text): query AMP-IMG by alt text, too #1048
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For my customer, I have to implement <amp-img /> in React. I would love to be able to use the existing RTL tooling.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit b71fcd8:
|
|
Relates to #1049 |
4 tasks
|
Closing in favour of #1049. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For my customer, I have to implement in React. I would love to be able to use the existing RTL tooling.
This is my first PR against this project. I have read the CONTRIBUTING.md and looked at some PRs before opening this one (using GitHub's web UI).
As I am not sure, what the project thinks about AMP (Accelerated Mobile Pages), I am only touching the code lightly before investing too much energy.
We have a workaround in place right now, that sidesteps RTL.
What:
The CONTRIBUTING.md does not indicate to open an issue before a PR, so there is no reference to be made.
This PR adds
amp-imgto the elements to query for selection by alt text.Why:
Right now, there is no other way (not even by means of a plugin) to use React Testing Library for AMP projects.
How:
I added
amp-imgto the selector list.Checklist:
I left these open for now to sense the waters first.
docs site