allow queryAllByText to select text nodes text content

[tylerthehaas]

closes issue #207

[kentcdodds]

Sweet 💯

[kentcdodds]

@all-contributors please add @tylerthehaas for code and tests

[allcontributors]

@kentcdodds

I've put up a pull request to add @tylerthehaas! 🎉

[kentcdodds]

🎉 This PR is included in version 3.16.6 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[gnapse]

After this was merged, I'm getting container.matches is not a function using cypress-testing-library. Any ideas why this could be?

Update: I can confirm it was this change. I edited my package json to force it to resolve dom-testing-library to v3.16.5 (the version prior to this being released) and my tests passed.

My cypress test's use of this library is a mere cy.getByLabelText('User name').type('john') (it's a new project and I'm just starting to write tests to it).

[kentcdodds]

Hmmmm.. could you figure out what's going on? Maybe we need to just do a typeof check?

[gnapse]

I'll try to carve out time to attempt to create a minimal reproduction repo, if no one has a brilliant idea before I can do that.

I initially suspected this element.matches thing was not supported by Cypress browser environment (as it happens, for instance, with EventTarget) but that seems unlikely, since that element method seems to have full support across all browsers.

[tylerthehaas]

The issue here is that cypress testing library is passing the document as the container. We should be able to do a check to make sure that container.matches is a function and that should solve this. I wont have time to implement this until after work tonight but will try to find time to do this if no one else gets to it before me.

[kentcdodds]

Agreed 👍

[ruyaoyao]

TypeError: container.matches is not a function is happening to me too, while I was passing window.document to getByText in jest.

[valscion]

I've got a working fix for this, with a new test case that would fail. I'll create a PR shortly

EDIT: See #213 for a fix