Wait for element to be removed #218
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,7 +6,6 @@ cache: | |
| notifications: | ||
| email: false | ||
| node_js: | ||
| - '10' | ||
| - '8' | ||
| install: npm install | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,20 +1,6 @@ | ||
| const baseConfig = require('kcd-scripts/jest') | ||
|
|
||
| module.exports = { | ||
|
There was a problem hiding this comment. Honestly, running all the exact same tests in Also, I don't think it's worthwhile to have tests for node. I'm pretty sure there's a very small number of people who benefit from this. |
||
| ...baseConfig, | ||
| testEnvironment: 'jest-environment-jsdom', | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,4 @@ | ||
| import {fireEvent} from '..' | ||
|
|
||
| const eventTypes = [ | ||
| { | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| import 'jest-dom/extend-expect' | ||
| import {waitForElementToBeRemoved} from '../' | ||
| import {render} from './helpers/test-utils' | ||
|
|
||
| jest.useFakeTimers() | ||
|
|
||
| test('requires a function as the first parameter', () => { | ||
| return expect( | ||
| waitForElementToBeRemoved(), | ||
| ).rejects.toThrowErrorMatchingInlineSnapshot( | ||
| `"waitForElementToBeRemoved requires a function as the first parameter"`, | ||
| ) | ||
| }) | ||
|
|
||
| test('requires an element to exist first', () => { | ||
| return expect( | ||
| waitForElementToBeRemoved(() => null), | ||
| ).rejects.toThrowErrorMatchingInlineSnapshot( | ||
| `"The callback function which was passed did not return an element or non-empty array of elements. waitForElementToBeRemoved requires that the element(s) exist before waiting for removal."`, | ||
| ) | ||
| }) | ||
|
|
||
| test('requires an unempty array of elements to exist first', () => { | ||
| return expect( | ||
| waitForElementToBeRemoved(() => []), | ||
| ).rejects.toThrowErrorMatchingInlineSnapshot( | ||
| `"The callback function which was passed did not return an element or non-empty array of elements. waitForElementToBeRemoved requires that the element(s) exist before waiting for removal."`, | ||
| ) | ||
| }) | ||
|
|
||
| test('times out after 4500ms by default', () => { | ||
| const {container} = render(`<div></div>`) | ||
| const promise = expect( | ||
| waitForElementToBeRemoved(() => container), | ||
| ).rejects.toThrowErrorMatchingInlineSnapshot( | ||
| `"Timed out in waitForElementToBeRemoved."`, | ||
| ) | ||
| jest.advanceTimersByTime(4501) | ||
| return promise | ||
| }) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| import 'jest-dom/extend-expect' | ||
| import {waitForElementToBeRemoved} from '../' | ||
| import {renderIntoDocument} from './helpers/test-utils' | ||
|
|
||
| test('resolves on mutation only when the element is removed', async () => { | ||
| const {queryAllByTestId} = renderIntoDocument(` | ||
| <div data-testid="div"></div> | ||
| <div data-testid="div"></div> | ||
| `) | ||
| const divs = queryAllByTestId('div') | ||
| // first mutation | ||
| setTimeout(() => { | ||
| divs.forEach(d => d.setAttribute('id', 'mutated')) | ||
| }) | ||
| // removal | ||
| setTimeout(() => { | ||
| divs.forEach(div => div.parentElement.removeChild(div)) | ||
| }, 100) | ||
| // the timeout is here for two reasons: | ||
| // 1. It helps test the timeout config | ||
| // 2. The element should be removed immediately | ||
| // so if it doesn't in the first 100ms then we know something's wrong | ||
| // so we'll fail early and not wait the full timeout | ||
| await waitForElementToBeRemoved(() => queryAllByTestId('div'), {timeout: 200}) | ||
| }) | ||
|
|
||
| test('resolves on mutation if callback throws an error', async () => { | ||
| const {getByTestId} = renderIntoDocument(` | ||
| <div data-testid="div"></div> | ||
| `) | ||
| const div = getByTestId('div') | ||
| setTimeout(() => { | ||
| div.parentElement.removeChild(div) | ||
| }) | ||
| await waitForElementToBeRemoved(() => getByTestId('div'), {timeout: 100}) | ||
| }) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doing this opens us up to stuff like this: https://stackoverflow.com/questions/55059748/travis-jest-typeerror-cannot-assign-to-read-only-property-symbolsymbol-tostr
I think the benefit of testing an unstable version of node isn't worth stuff like this.