fix(events): fix firing events in document #222
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Fix firing events in the document element.
Fixes #159, as per @kentcdodds suggestion in #159 (comment).
Why:
Currently firing events in the document element throws a
TypeError: Cannot read property 'defaultView' of null
when trying to usefireEvent
"shortcut API" (not sure this is its name :)):fireEvent.keyDown(document, { key: 'Escape' })
It was possible to fire events in the document by using
fireEvent
directly, like so:fireEvent(document, new KeyboardEvent('keydown', { key: 'Escape' }))
How:
Falling back to
node
to getdefaultView
from, whennode.ownerDocument
isnull
.Checklist: