Skip to content

fix(ByLabel): use getNodeText abstraction instead of textContent #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 19, 2019

Conversation

kentcdodds
Copy link
Member

What: fix(ByLabel): use getNodeText abstraction instead of textContent

Why: Closes #190

How: Make queryAllByLabelText use getNodeText instead of textContent

Also, I formatted everything 🤷‍♂️

Checklist:

  • Documentation added to the docs site N/A
  • Typescript definitions updated N/A
  • Tests N/A
  • Ready to be merged

@codecov
Copy link

codecov bot commented Mar 19, 2019

Codecov Report

Merging #227 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #227   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          13     13           
  Lines         293    293           
  Branches       68     68           
=====================================
  Hits          293    293
Impacted Files Coverage Δ
src/wait-for-element.js 100% <100%> (ø) ⬆️
src/get-node-text.js 100% <100%> (ø) ⬆️
src/queries.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e182885...c337ea1. Read the comment docs.

@kentcdodds kentcdodds merged commit 96f21a5 into master Mar 19, 2019
@kentcdodds kentcdodds deleted the pr/label-text branch March 19, 2019 21:20
@kentcdodds
Copy link
Member Author

🎉 This PR is included in version 3.18.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

kentcdodds pushed a commit that referenced this pull request Mar 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant