Fix typings of getQueriesForElement #246
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Fix typings of getQueriesForElement function
Why:
There are currently two problems:
queriesToBind
parameter isBoundFunctions<typeof queries> | BoundFunctions<typeof queries>[]
which is IMO incorrect because the function is doing the binding and thus should receive unbound queries.BoundFunctions
is hardcoded totypeof queries
which prevents binding of custom queriesHow:
getQueriesForElement
to enable binding custom queriesqueriesToBind
to type parameterChecklist: