Skip to content

feat(typings): allow document to be used in fireEvent #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 1, 2019
Merged

feat(typings): allow document to be used in fireEvent #272

merged 1 commit into from
Jun 1, 2019

Conversation

foray1010
Copy link
Contributor

What:

Allow Document type to be used in fireEvent

Why:

Document is not a subtype of Element nor Window

Checklist:

  • Documentation added to the
    docs site
  • Typescript definitions updated
  • Tests
  • Ready to be merged

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super. Thanks!

@kentcdodds kentcdodds merged commit 43d32f5 into testing-library:master Jun 1, 2019
@kentcdodds
Copy link
Member

@all-contributors please add @foray1010 for code

@allcontributors
Copy link
Contributor

@kentcdodds

I've put up a pull request to add @foray1010! 🎉

@kentcdodds
Copy link
Member

🎉 This PR is included in version 5.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants