Skip to content

feat: Add pointer events #295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 24, 2019

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Jun 23, 2019

What:

Add Pointer events to fireEvent.

Why:

Consistent with other implemented events

How:

Add each event in https://developer.mozilla.org/en-US/docs/Web/API/Pointer_events#Event_types_and_Global_Event_Handlers and use defaults as described in the corresponding event page e.g. https://developer.mozilla.org/en-US/docs/Web/API/HTMLElement/gotpointercapture_event

Checklist:

  • [ ] Documentation added to the
    docs site
    Don't think that's necessary since I didn't find docs for specific events.
  • Typescript definitions updated
  • Tests
  • Ready to be merged

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic 🎉

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super. Thank you!

@kentcdodds kentcdodds merged commit 12e0f4f into testing-library:master Jun 24, 2019
@kentcdodds
Copy link
Member

@all-contributors please add @eps1lon for tests

@allcontributors
Copy link
Contributor

@kentcdodds

I've put up a pull request to add @eps1lon! 🎉

@kentcdodds
Copy link
Member

Thanks so much for your help! I've added you as a collaborator on the project. Please make sure that you review the other/MAINTAINING.md and CONTRIBUTING.md files (specifically the bit about the commit messages and the git hooks) and familiarize yourself with the code of conduct (we're using the contributor covenant). You might also want to watch the repo to be notified when someone files an issue/PR. Please continue to make PRs as you feel the need (you can make your branches directly on the repo rather than your fork if you want). Thanks! And welcome to the team :)

@kentcdodds
Copy link
Member

🎉 This PR is included in version 5.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants