Skip to content

fix: byLabel crashing in IE 11 #363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Sep 25, 2019

What:

Why:

  • Crashes in IE 11 when using byRoles

How:

  • Wrap in Array.from

Checklist:

@eps1lon eps1lon added the bug Something isn't working label Sep 25, 2019
Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I never know whether array methods are supported on a NodeList or not (it seems to work at random even in my Chrome dev console.

@kentcdodds kentcdodds merged commit a401bb5 into testing-library:master Sep 26, 2019
@kentcdodds
Copy link
Member

🎉 This PR is included in version 6.4.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@eps1lon
Copy link
Member Author

eps1lon commented Sep 27, 2019

I never know whether array methods are supported on a NodeList or not (it seems to work at random even in my Chrome dev console.

I would've never known either 😄

@eps1lon eps1lon deleted the fix/querySelectorAll-forEach branch September 27, 2019 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants