-
Notifications
You must be signed in to change notification settings - Fork 469
feat(events): add form reset event #368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(events): add form reset event #368
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, thank you for your help here! If you could update the test as you suggested that would be great 💯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@all-contributors please add @pheeria for code and tests |
I've put up a pull request to add @pheeria! 🎉 |
🎉 This PR is included in version 6.5.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Hi all!
This is my first PR to a popular OSS project.
What:
Forms have
submit
, but lackreset
event.Why:
Using form events instead of direct button callbacks comes handy sometimes, when using form templates with variable content.
How:
Events were extended to contain
reset
event applicable on<form />
tags.Checklist:
https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/testing-library__dom
Comments: