test(ci): use latest 10 LTS release

[alexkrolick]

Closes #521

[alexkrolick]

I don't know if these are valid versions for config, kicking CI to see

[alexkrolick]

It works https://travis-ci.org/github/testing-library/dom-testing-library/builds/673703620

[codesandbox-ci]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 47f8d0c:

Sandbox	Source
kind-thunder-pv0nr	Configuration

[codecov]

Codecov Report

Merging #525 into master will not change coverage by %.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #525   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           23        23           
  Lines          429       429           
  Branches       103       103           
=========================================
  Hits           429       429           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98e4a9a...47f8d0c. Read the comment docs.

[MichaelDeBoey]

I wouldn’t merge this PR for 2 reasons:

1. It’s a breaking change
2. This will run the tests on latest Node 10 and I think we want to make sure the package is working on the lowest supported version.
   This way we can’t be sure it keeps working on 10.0

The breaking change should be reverted upstream instead.

[alexkrolick]

• It's not a breaking change, this is for our devDeps.
  • Unless you mean the engines field (?)
• CI already runs on Node 10 and 12 (but is failing on Node 10.0.0), this does the same, but uses the latest 10.x and 12.x releases.
• Feel free to communicate this upstream but my impression is they had a good reason to raise their minimum supported version due to accuracy issues.

[MichaelDeBoey]

@alexkrolick It's indeed breaking, since you're now saying the package can only be consumed by Node 10.4 instead of 10.0.

CI is testing for CI 10.0 (the minimum supported version), so if we change that to 10 or dubnium the latest 10.x (which is 10.20) will be used.
That will not insure us anymore that our code is working on 10.0.

Right now CI is failing for 10.0, because of the changes in webidl-conversions.
They released a major release for this, so they're good.

The problem is that jsdom changed it's dependency to [email protected] without making this a breaking change on their side (see jsdom/jsdom@fe164b3).

Fixing this in jsdom, would fix our CI again.

[kentcdodds]

I honestly am not concerned about running CI against the latest 10 version and just hoping we don't break 10.0.0. I think it's pretty unlikely that we will break 10.0.0 and if we do it's not a lot of work to fix it.

[MichaelDeBoey]

We will know something breaking a lot faster in the process, which will cause less bug reports, ...

Not my call to make, but that's why I think we shouldn't use latest Node 10.x

[kentcdodds]

You're not wrong. I just see the risk as low and the reward as high so I'm willing to take it.

[kentcdodds]

Not only a lot risk, but also a lot impact as well.

[alexkrolick]

We could run CI against the lowest version and all the current lts versions we support. That would be 10.0.0, lts/dubnium, lts/erbium.

But what to do with the engines field? Our JSDOM dep has silently raised the number from 10.0.0 to 10.4.0. Do we want to leave it at 10.0.0, keep running CI against 10.0.0, and have it fail until upstream reverts or patches?

[kentcdodds]

Let's leave engines as they are and bump CI just so we can get it working. Just because we're having trouble with our development dependencies doesn't mean other people should suffer the consequences of that.

[eps1lon]

Running with the latest node version is in line with how we treat dependencies in CI: We always install the latest version since we don't have a lockfile that pinnes the versions to the minimal possible.

[kentcdodds]

👍

Thanks everyone!

[kentcdodds]

🎉 This PR is included in version 7.2.2 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀