Get element by label input value and by labels concat values

[delca85]

What:

• getAllLabelsByText now retrieves label by input elements not empty value too

• getByLabelText accepts a new argument named concat that enables retrieving elements by multiple concatenated labels

Why:
According to #545 retrieving element through input labels was impossible as well as using a combination of labels to get a labelled element.

How:

1. queryAllLabelsByText now makes a query not only on elements of type label but on input elements too. The empty input are excluded.
2. in order to make queryAllLabelsByText gets the labels even if the text to be matched is a concatenation of labels, the concat argument is passed to the matcher. The matcher checks the value of concat to decide if the condition to be satisfied is an equality or an includes (in case of concat true) condition between the text and the candidate label.
3. a last check is performed to know if all the provided text is composed by the found labels

Checklist:

• add input type to elements queried by queryAllLabelsByText
• remove input elements with empty value
• add concat argument to all the methods called in the chain
• change matcher behavior according to concat value
• check if the labels compose the received text to be matched

• Documentation added to the
  docs site
• I've prepared a PR for types targeting
  DefinitelyTyped
• Tests
• Ready to be merged
  

Like said in #545 comments, I am not sure this is the right way to fix this wrong behavior and probably I am not considering some use case but I would like to receive some suggestions and share thoughts on it.

[codesandbox-ci]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a89ec7f:

Sandbox	Source
fancy-worker-p3j8v	Configuration

[kentcdodds]

Hi @delca85! Thank you for this. This is a pretty hard problem. Unfortunately, I'm not sure that this is the right solution, but I don't know what the right solution is 😬 To compound on that, I don't have bandwidth to invest into this myself right now, so I'm calling on the rest of the @testing-library/all-maintainers (and anyone else seeing my bat signal 🦇) to come help us collaborate on a proper solution for this use case.

Sorry I can't be of more help.

[delca85]

Hi @kentcdodds! It was a pleasure for me to work on this. I would be happy to understand a bit more about the right solution so I hope your call will make someone help us!

[kentcdodds]

I think we can close this one now :) Thanks again!