Adds matcher name to multiple elements error

[jacobparis]

What:
The getByRole queries are designed to return a single element whose role matches the provided role argument and whose accessible name matches the provided name argument.

When multiple elements are matched, the language in the error message only mentions the role and not the accessible name.

Sample query

screen.getByRole('definition', { name: /value/i })

Current error message

TestingLibraryElementError: Found multiple elements with the role "definition"

New error messages

TestingLibraryElementError: Found multiple elements with the role "definition" and name "value"

TestingLibraryElementError: Found multiple elements with the role "definition" and name `/value/i`

Why:

When you have several queries against the same role but for different accessible names, the error messages produced by them are identical. The only way to figure out which name is finding duplicates is to look at the code trace.

How:

The information including the accessible name parameter was already provided to the error message handler. The logic for displaying the name with or without quotes depending on its type was already present in the getMissingError handler, so I copied it to the getMultipleError handler

Checklist:

• Documentation added to the
  docs site N/A
• Tests
• Typescript definitions updated N/A
• Ready to be merged
  

[codesandbox-ci]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 1febc64:

Sandbox	Source
icy-breeze-hc34r	Configuration

[kentcdodds]

Love it. Thanks! Could you add a test for this as well?

[jacobparis]

There did not appear to be a test explicitly covering the multiple element error in the first place so I've added a new one

[kentcdodds]

Looks like we're not quite there on coverage. Let me know if you need help identifying what's left.

[jacobparis]

Just pushed up the missing test

[codecov]

Codecov Report

Merging #677 into master will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #677   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           24        24           
  Lines          596       602    +6     
  Branches       148       151    +3     
=========================================
+ Hits           596       602    +6     

Impacted Files	Coverage Δ
src/queries/role.js	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 373dbc4...1febc64. Read the comment docs.

[kentcdodds]

Cool 👍

[kentcdodds]

@all-contributors please add @jacobparis for code and tests

[allcontributors]

@kentcdodds

I've put up a pull request to add @jacobparis! 🎉

[kentcdodds]

🎉 This PR is included in version 7.18.2 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀