Skip to content

Typo fix #704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 20, 2020
Merged

Typo fix #704

merged 2 commits into from
Jul 20, 2020

Conversation

DenrizSusam
Copy link
Contributor

@DenrizSusam DenrizSusam commented Jul 19, 2020

What:

Why:

How:

Checklist:

  • Documentation added to the
    docs site
  • Tests
  • Typescript definitions updated
  • Ready to be merged

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 19, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9e3bb8c:

Sandbox Source
kentcdodds/react-testing-library-examples Configuration

nickserv
nickserv previously approved these changes Jul 19, 2020
@nickserv
Copy link
Member

I'm fine with merging this, but I don't remember how to properly make a semantic commit without publishing a new version

@marcosvega91
Copy link
Member

marcosvega91 commented Jul 19, 2020

I think that you can merge with a commit of type docs

@kentcdodds
Copy link
Member

We don't want a release for this, otherwise it doesn't matter much. https://www.conventionalcommits.org/en/v1.0.0/#specification

@kentcdodds kentcdodds merged commit 338a38d into testing-library:master Jul 20, 2020
@kentcdodds
Copy link
Member

@all-contributors please add @DenrizSusam for code

@allcontributors
Copy link
Contributor

@kentcdodds

I've put up a pull request to add @DenrizSusam! 🎉

@kentcdodds
Copy link
Member

🎉 This PR is included in version 7.21.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants