Issue 707- getByLabelText does not work with some IDs when using aria-labelledby #708
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 2bb60d8:
|
|
@all-contributors please add @ryuuji3 for code and tests |
|
I've put up a pull request to add @ryuuji3! 🎉 |
|
🎉 This PR is included in version 7.21.3 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
Sweet, thank you very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: When using aria-labelledby, getByLabelText should account for a selector that might need quotes around it.
Why: In such a case, the selector is invalid causing unexpected test failures
How: Just a one line change to wrap quotes around the id in the selector.
Checklist:
docs site N/A
Closes #707