Add missing config fields to type #724
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 07e702c:
|
Codecov Report
@@ Coverage Diff @@
## master #724 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 24 24
Lines 646 646
Branches 168 168
=========================================
Hits 646 646 Continue to review full report at Codecov.
|
nickserv
requested changes
Jul 29, 2020
|
🎉 This PR is included in version 7.21.7 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Adding fields to the Config type to support the options that are documented.
Why:
Without adding these fields to the types, using them in projects which support types will cause errors or require exceptions to type enforcement. Example provided in issue #721
How:
Adding fields to existing Config type.
Checklist:
docs site
I'll caveat this with saying that I'm not sure exactly how the type tests work. Would it make sense to add a function there that attempts to set each of the fields (or all of the fields at once) on the configuration to verify that there aren't type errors there?