Skip to content

chore: create pull request template #426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 21, 2021
Merged

chore: create pull request template #426

merged 4 commits into from
Jul 21, 2021

Conversation

HonkingGoose
Copy link
Contributor

@HonkingGoose HonkingGoose commented Jul 21, 2021 •
edited
Loading

Checks

  • I have read the contributing guidelines.
  • If some rule is added/updated/removed, I've regenerated the rules list.
  • If some rule meta info is changed, I've regenerated the plugin shared configs.

Changes

  • Create pull request template

Context

Helps with issue #400, but does not close it.

Belco90
Belco90 requested changes Jul 21, 2021
View reviewed changes
Copy link
Member

@Belco90 Belco90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small nitpick, but looks good.

@HonkingGoose HonkingGoose requested a review from Belco90 July 21, 2021 15:29
@Belco90 Belco90 merged commit 9934f9c into testing-library:main Jul 21, 2021
@HonkingGoose HonkingGoose deleted the patch-1 branch July 21, 2021 15:43
@github-actions
Copy link

🎉 This PR is included in version 4.11.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Belco90 Belco90 Belco90 approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HonkingGoose @Belco90