Skip to content

feat: throw error when mixing props and svelte options #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 6, 2019
Merged

feat: throw error when mixing props and svelte options #63

merged 1 commit into from
Dec 6, 2019

Conversation

mihar-22
Copy link
Collaborator

@mihar-22 mihar-22 commented Dec 6, 2019

ref: #62

benmonro
benmonro reviewed Dec 6, 2019
View reviewed changes
Copy link
Member

@benmonro benmonro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm but I'll defer to @alexkrolick

@benmonro
Copy link
Member

benmonro commented Dec 6, 2019

Also please update the docs sure to reflect the change

@mihar-22 mihar-22 merged commit 0fd1527 into testing-library:master Dec 6, 2019
@mihar-22 mihar-22 deleted the pull-62 branch December 6, 2019 03:58
@benmonro
Copy link
Member

benmonro commented Dec 6, 2019

🎉 This PR is included in version 1.11.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benmonro benmonro benmonro left review comments

@alexkrolick alexkrolick alexkrolick approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mihar-22 @benmonro @alexkrolick