Skip to content

docs: Vitest doesn't need global-jsdom #1084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 8, 2022
Merged

docs: Vitest doesn't need global-jsdom #1084

merged 1 commit into from
Jun 8, 2022

Conversation

silvenon
Copy link
Contributor

@silvenon silvenon commented Jun 8, 2022

Vitest doesn't need global-jsdom, setting environment to jsdom already defines it globally.

@silvenon
docs: Vitest doesn't need global-jsdom
ce2f9e9 
Vitest doesn't need global-jsdom, setting `environment` to `jsdom` already defines it globally.
@eps1lon eps1lon merged commit 77da5d0 into testing-library:main Jun 8, 2022
@eps1lon
Copy link
Member

eps1lon commented Jun 8, 2022

@all-contributors add @silvenon for docs

@allcontributors allcontributors bot mentioned this pull request Jun 8, 2022
Merged
@allcontributors
Copy link
Contributor

@eps1lon

I've put up a pull request to add @silvenon! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eps1lon eps1lon eps1lon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@silvenon @eps1lon