docs: add custom queries example to custom render docs #152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kierenhughes
force-pushed
the
docs/add-custom-render-queries-example
branch
3 times, most recently
from
54d7850 to
259fbf9
Compare
alexkrolick
reviewed
Jun 20, 2019
alexkrolick
reviewed
Jun 20, 2019
afontcu
reviewed
Jun 20, 2019
kierenhughes
force-pushed
the
docs/add-custom-render-queries-example
branch
from
259fbf9 to
f46aaf8
Compare
kierenhughes
force-pushed
the
docs/add-custom-render-queries-example
branch
from
f46aaf8 to
f059027
Compare
kierenhughes
force-pushed
the
docs/add-custom-render-queries-example
branch
4 times, most recently
from
fbd51ee to
7dc39ba
Compare
|
Should probably explain a little what "cy" stands for but other than that LGTM |
kierenhughes
force-pushed
the
docs/add-custom-render-queries-example
branch
2 times, most recently
from
516945a to
5f81c5e
Compare
I've added a bit about that along with the link to the relevant Cypress.io docs regarding selecting by data-*. I've also added a recommendation around not needing to use your own queries and only doing so if your queries encourage testing in a user-centric way without focusing on implementation details. |
kierenhughes
force-pushed
the
docs/add-custom-render-queries-example
branch
from
5f81c5e to
cea8057
Compare
|
@all-contributors please add @kierenhughes for docs |
|
I've put up a pull request to add @kierenhughes! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following on from my previous PR (#151) and having noticed the discussion in #80:
In the example, I've create a data attribute selector for
data-cyas this is one of the attributes recommended by Cypress. I think in reality I would favour replacingdata-cyglobally throughout my projects withdata-testid, but this may be useful for some people not willing to refactor outdata-cy, or similar, at the moment.