Break React-Redux example into multiple "files" (code blocks) #167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous example put all the necessary variables into one file. However, this is unrealistic and I found it confusing when first reading through the docs. Instead, I've broken each chunk of this example into its own "file", which I think reads better and will be more applicable to a user's code base.
SeanMcP
changed the title
Gpx
approved these changes
Jun 28, 2019
kentcdodds
reviewed
Jun 28, 2019
docs/example-react-redux.md
Outdated
|
|
||
| For this example, we'll have a simple reducer that tracks and updates `count`: | ||
|
|
||
| ``` |
There was a problem hiding this comment.
Let's specify a language for this codefence for syntax highlighting
```js
|
@all-contributors please add @SeanMcP for docs |
|
I've put up a pull request to add @SeanMcP! 🎉 |
superT999
added a commit
to superT999/testing-library-docs
that referenced
this pull request
Feb 13, 2023
* Break example into multiple "files" The previous example put all the necessary variables into one file. However, this is unrealistic and I found it confusing when first reading through the docs. Instead, I've broken each chunk of this example into its own "file", which I think reads better and will be more applicable to a user's code base. * Specify JavaScript language on code block Per @kentcdodds' PR comment: testing-library/testing-library-docs#167 (comment)
web3gru
pushed a commit
to web3gru/testing-library-docs
that referenced
this pull request
May 13, 2023
* Break example into multiple "files" The previous example put all the necessary variables into one file. However, this is unrealistic and I found it confusing when first reading through the docs. Instead, I've broken each chunk of this example into its own "file", which I think reads better and will be more applicable to a user's code base. * Specify JavaScript language on code block Per @kentcdodds' PR comment: testing-library/testing-library-docs#167 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous example put all the necessary variables into one "file" (code block). However, this is unrealistic, and I found it confusing when first reading through the docs.
Instead, I've broken each chunk of this example into its own "file", which I think reads better and will be more applicable to a user's code base.