docs: include new page for eslint plugin within ecosystem section #275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afontcu
approved these changes
Oct 2, 2019
kentcdodds
requested changes
Oct 2, 2019
| that helps users to follow best practices and anticipate common mistakes when | ||
| writing tests. | ||
|
|
||
|  |
There was a problem hiding this comment.
Could we store this image within the repository rather than on imgur? I believe some countries/companies block imgur.
There was a problem hiding this comment.
sure! I did that at first but wasn't sure if it was the right decision. Included at the repo now.
| title: eslint-plugin-testing-library | ||
| --- | ||
|
|
||
| [`eslint-plugin-testing-library`][gh] is an ESLint plugin for `Testing Library` |
There was a problem hiding this comment.
Testing Library does not need to be in backticks I think.
|
|
||
| This plugin includes: | ||
|
|
||
| - several rules for linting `Testing Library` specific code |
afontcu
reviewed
Oct 2, 2019
|
|
||
| This plugin includes: | ||
|
|
||
| - several rules for linting Testing Library specific code |
There was a problem hiding this comment.
Suggested change
| - several rules for linting Testing Library specific code | |
| - Several rules for linting Testing Library specific code. |
same thing in the other ones 😇 sry for the nitpicking.
|
@all-contributors please add @Belco90 for docs |
|
I've put up a pull request to add @Belco90! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating doc to include new ecosystem section with eslint-plugin-testing-library.
After the original idea about writing an ESLint plugin for Testing Library I'm really excited for releasing v1 and update the proper ecosystem doc here!
I don't know if I would need to specify more things on this section, all the info is actually on Github page.