Skip to content

Fix react-testing-library FAQ broken links (#321) #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 15, 2019
Merged

Fix react-testing-library FAQ broken links (#321) #48

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
18dfe97
Fix react-testing-library missing links (#321)
bernardobelchior Mar 15, 2019
a3b2210
Merge branch 'master' into patch-1
alexkrolick Mar 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions docs/react-testing-library/faq.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ As you write your tests, keep in mind:
<summary>If I can't use shallow rendering, how do I mock out components in tests?</summary>

In general, you should avoid mocking out components (see
[the Guiding Principles section](./guiding-principles)). However if you need to,
[the Guiding Principles section](../guiding-principles)). However if you need to,
then it's pretty trivial using
[Jest's mocking feature](https://facebook.github.io/jest/docs/en/manual-mocks.html).
One case that I've found mocking to be especially useful is for animation
Expand Down Expand Up @@ -116,14 +116,14 @@ test('you can mock things with jest.mock', () => {
Note that because they're Jest mock functions (`jest.fn()`), you could also make
assertions on those as well if you wanted.

[Open full test](./example-react-transition-group) for the full example.
[Open full test](../example-react-transition-group) for the full example.

This looks like more work that shallow rendering (and it is), but it gives you
more confidence so long as your mock resembles the thing you're mocking closely
enough.

If you want to make things more like shallow rendering, then you could do
something more [like this]([Open full test](./example-react-transition-group) ).
something more [like this]([Open full test](../example-react-transition-group) ).

Learn more about how Jest mocks work from my blog post:
["But really, what is a JavaScript mock?"](https://blog.kentcdodds.com/but-really-what-is-a-javascript-mock-10d060966f7d)
Expand Down